Mike Kolesnik has posted comments on this change.
Change subject: engine: Modify Network Assign to Cluster Command permissions
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java
Line 164: @Override
Line 165: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 166: List<PermissionSubject> permissions = new
ArrayList<PermissionSubject>();
Line 167:
Line 168: Guid networkId = getParameters().getNetwork() == null ? null
: getParameters().getNetwork().getId();
Why not get it from the NetworkCluster field?
Line 169: // require permissions on network
Line 170: permissions.add(new PermissionSubject(networkId,
Line 171: VdcObjectType.Network,
Line 172: getActionType().getActionGroup()));
Line 180: return permissions;
Line 181: }
Line 182:
Line 183: /**
Line 184: * Checks the user has permissions either on Network or on
Cluster for this action.<br>
<br> is not necessary here
Line 185: */
Line 186: @Override
Line 187: protected boolean checkPermissions(final List<PermissionSubject>
permSubjects) {
Line 188: List<String> messages = new ArrayList<String>();
--
To view, visit http://gerrit.ovirt.org/9540
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1edaeaf323a7a5b7c407e06d2ff9e3dae3430a
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
