travisspencer commented on pull request #578:
URL: https://github.com/apache/logging-log4j2/pull/578#issuecomment-915786974
Great. Thanks, @carterkozak .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
schlosna commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r705830363
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/LevelPatternConverter.java
##
@@ -123,7 +120,7 @@ private static Strin
schlosna commented on pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-916568200
I would definitely be interested to see benchmark comparisons for before &
after. I imagine the results may depend on the distinct number and shape of
formatter patterns u
carterkozak commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r706235288
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/LevelPatternConverter.java
##
@@ -123,7 +120,7 @@ private static St
carterkozak commented on pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-916958889
Thanks for the links! I'm planning to benchmark the individual changes as
well as end-to-end impact. I'd meant to open this as a draft, this is currently
very much an e
carterkozak commented on pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-916965179
I imagine there's something clever (aka risky/unmaintainable/fun) we could
do with layouts using bytecode generation to avoid some amount of overhead.
Definitely want t
carterkozak opened a new pull request #579:
URL: https://github.com/apache/logging-log4j2/pull/579
Very slightly reduces indirection to access the appender array.
Updates are relatively rare so we don't need to worry about
noisy neighbors.
--
This is an automated message from the Ap
carterkozak opened a new pull request #580:
URL: https://github.com/apache/logging-log4j2/pull/580
Static threadlocal field `recursionDepthHolder` is final
Deduplication in `decrementRecursionDepth()`
handleLogMessageException uses interpolation to avoid overhead
when warnings are d
carterkozak commented on pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-917236154
Initial benchmarks on this branch look promising -- writing through a
RandomAccessFile appender to `/dev/null` `-Dlog4j2.enable.direct.encoders=false
-Dlog4j2.formatMsg
ams-tschoening commented on a change in pull request #70:
URL: https://github.com/apache/logging-log4cxx/pull/70#discussion_r706822667
##
File path: src/main/cpp/domconfigurator.cpp
##
@@ -1035,6 +1037,19 @@ void DOMConfigurator::parse(
MessageBufferUseStaticStr
dependabot[bot] closed pull request #559:
URL: https://github.com/apache/logging-log4j2/pull/559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
dependabot[bot] commented on pull request #559:
URL: https://github.com/apache/logging-log4j2/pull/559#issuecomment-917822152
Superseded by #581.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] opened a new pull request #581:
URL: https://github.com/apache/logging-log4j2/pull/581
Bumps tomcat-catalina from 8.5.20 to 10.0.11.
[;
rm5248 commented on a change in pull request #70:
URL: https://github.com/apache/logging-log4cxx/pull/70#discussion_r708767899
##
File path: src/site/markdown/threading.md
##
@@ -88,6 +93,27 @@ call, as there is an internal mutex that is locked and
unlocked in order to ensu
o
rm5248 merged pull request #70:
URL: https://github.com/apache/logging-log4cxx/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
nturner commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-921184615
Sorry; been busy. Yes, @rm5248, if I use a configuration like the example in
LOGCXX-523, logging appears to continue. That approach results in a more
complex configuration (
rm5248 commented on pull request #62:
URL: https://github.com/apache/logging-log4cxx/pull/62#issuecomment-921343014
> Sorry; been busy. Yes, @rm5248, if I use a configuration like the example
in LOGCXX-523, logging appears to continue. That approach results in a more
complex configuration
agsha opened a new pull request #582:
URL: https://github.com/apache/logging-log4j2/pull/582
https://issues.apache.org/jira/browse/LOG4J2-3162
In the documentation of RollingFileAppender
> immediateFlush boolean When set to true - the default, each write will be
followed b
ams-tschoening commented on pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-922244507
It would be great to not only put a bunch of code here, but as well describe
your use-case, the chosen implementation, limitations, how things are used in
the end etc
rm5248 commented on pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-922340153
Looks good to me, but I agree with Thorsten that at least some documentation
is needed(currently, the documentation for the conversion characters is in the
documentation for
craterone commented on pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-922405875
> Looks good to me, but I agree with Thorsten that at least some
documentation is needed(currently, the documentation for the conversion
characters is in the documentation
rm5248 commented on pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-922464745
> > There are a few errors on Windows(you missed a few LOG4CXX_STR macros on
string constants).
>
> Sorry, I don't figure it out. Could you give me a hint?
>
vy commented on pull request #582:
URL: https://github.com/apache/logging-log4j2/pull/582#issuecomment-922682364
@agsha Thanks so much for the contribution! I will backport this to
`release-2.x` too.
--
This is an automated message from the Apache Git Service.
To respond to the message,
vy merged pull request #582:
URL: https://github.com/apache/logging-log4j2/pull/582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
dependabot[bot] opened a new pull request #583:
URL: https://github.com/apache/logging-log4j2/pull/583
Bumps openjdk from 8 to 17.
[
### Description
Replace test class
[StoringStatusListener](https://github.com/apache/logging-
wx930910 commented on pull request #584:
URL: https://github.com/apache/logging-log4j2/pull/584#issuecomment-923680213
If we only want to make sure that the `log(StatusData)` method execution
status, we can verify it by using `Mockito.times()` and get rid of the
ArgumentCapture. It can mak
rgoers commented on pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-923720165
I cloned your repo and checked out this branch. When I run the build all the
RollingFileAppender tests fail and RollingAppenderDeleteScriptFri13thTest is
permanently stuck i
garydgregory commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713152109
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java
##
@@ -0,0 +1,119 @@
+/*
+ * Li
carterkozak commented on pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-924095311
Sorry, Ralph. I've updated this branch with a fix. I'm going to PR something
into the release branch separately to improve messaging/behavior in that case
because it's
garydgregory commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713153477
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java
##
@@ -0,0 +1,119 @@
+/*
+ * Li
garydgregory commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713154271
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java
##
@@ -0,0 +1,119 @@
+/*
+ * Li
garydgregory commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713155032
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java
##
@@ -0,0 +1,119 @@
+/*
+ * Li
carterkozak commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713154918
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java
##
@@ -669,20 +668,20 @@ private int finalizeCon
carterkozak commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713155432
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java
##
@@ -0,0 +1,119 @@
+/*
+ * Lic
garydgregory commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713156919
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java
##
@@ -0,0 +1,119 @@
+/*
+ * Li
garydgregory commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713156919
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java
##
@@ -0,0 +1,119 @@
+/*
+ * Li
garydgregory commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713151635
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java
##
@@ -669,20 +668,20 @@ private int finalizeCo
carterkozak commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713214204
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/SimpleLiteralPatternConverter.java
##
@@ -0,0 +1,119 @@
+/*
+ * Lic
vy commented on pull request #584:
URL: https://github.com/apache/logging-log4j2/pull/584#issuecomment-924330636
Thanks so much for the contribution @wx930910! Mocking is definitely a
better approach, since it allows (backward-compatible) evolution of
`StatusListener` without breaking test
carterkozak commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713390780
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/LogEventFactory.java
##
@@ -28,8 +28,21 @@
/**
*
*/
-public inter
carterkozak commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713391653
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
##
@@ -88,9 +88,10 @@ public boolean requi
carterkozak commented on pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-924387654
> imagine the results may depend on the distinct number and shape of
formatter patterns used in an application, as that may push C2 to optimize
differently for monomor
wx930910 commented on pull request #584:
URL: https://github.com/apache/logging-log4j2/pull/584#issuecomment-924494400
@vy Thanks for your comments! Make sence to me, I changed the code
corresponding to your advice :+1:
--
This is an automated message from the Apache Git Service.
To res
rm5248 commented on pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-925452437
The code looks good to me at this point - if you could just add some
documentation to `patternlayout.h` documenting the new conversion characters,
I'll go ahead and merge it.
craterone commented on pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-925453405
I'll do it as soon as possible, a little busy this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
vy merged pull request #584:
URL: https://github.com/apache/logging-log4j2/pull/584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
zhurs commented on pull request #481:
URL: https://github.com/apache/logging-log4j2/pull/481#issuecomment-927594238
@rgoers
I met this problem in my production.
What can we do to merge this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message,
rm5248 merged pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
rm5248 merged pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
Dretch opened a new pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585
This fixes https://issues.apache.org/jira/browse/LOG4J2-3170
PS. Although this the passes tests that seem relevant, I could not get the
entire project to build. I could not find a build of J
vy merged pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585#issuecomment-933018911
Thanks so much @Dretch! Ported the changes to `master` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vy commented on pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585#issuecomment-933019504
@Dretch, for the records, you need to have two JDKs available in your system
to be able to compile `release-2.x`:
1. Java 8
1. Java 9+ (11, etc. is okay too)
The
dependabot[bot] opened a new pull request #586:
URL: https://github.com/apache/logging-log4j2/pull/586
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.3.0
to 2.3.1.
Release notes
Sourced from https://github.com/actions/setup-java/releases";>actions/setup-j
dependabot[bot] commented on pull request #575:
URL: https://github.com/apache/logging-log4j2/pull/575#issuecomment-933224323
Superseded by #586.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] closed pull request #575:
URL: https://github.com/apache/logging-log4j2/pull/575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: n
Dretch commented on pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585#issuecomment-933250517
Thanks @vy , I had not tried the combination of JDK 8 and JDK 11 before.
However, this still has the issue with `sun.reflect.Reflection` not being
there:
My `~/
carterkozak commented on pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585#issuecomment-933870484
I think you need both installed, and also to `export
JAVA_HOME=/path/to/jdk8home`
--
This is an automated message from the Apache Git Service.
To respond to the messa
vy commented on pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585#issuecomment-934149140
@Dretch, mind trying the following, please?
1. Switch to Java 8
1. Run `./mvnw clean package -DskipTests=true` in `release-2.x` branch.
Note that `mvnw` needs to
vy merged pull request #586:
URL: https://github.com/apache/logging-log4j2/pull/586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
Dretch commented on pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585#issuecomment-937822797
@vy that works -- thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Dretch commented on pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585#issuecomment-937822797
@vy that works -- thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
carterkozak commented on pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-939088609
Testing locally passes, CI builds are also passing. Planning to merge this
shortly.
--
This is an automated message from the Apache Git Service.
To respond to the mes
wuqian0808 opened a new pull request #587:
URL: https://github.com/apache/logging-log4j2/pull/587
Avoid kafka with new topic configuration get overried by the old one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
rgoers commented on pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-939362471
I ran the build again and everything passed for me. The failures I saw I
have gotten randomly before so I am sure it wasn’t anything you did.
Ralph
> On Oct 8,
dschwartzni opened a new pull request #76:
URL: https://github.com/apache/logging-log4net/pull/76
A small change in AssemblyInfo allows the netstandard2.0 libraries to be
used with net4.72 asp.net web services
--
This is an automated message from the Apache Git Service.
To respond to the
carterkozak merged pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notif
wuqian0808 closed pull request #587:
URL: https://github.com/apache/logging-log4j2/pull/587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifi
wuqian0808 commented on pull request #587:
URL: https://github.com/apache/logging-log4j2/pull/587#issuecomment-945538590
replace with new pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wuqian0808 commented on pull request #590:
URL: https://github.com/apache/logging-log4j2/pull/590#issuecomment-945539336
@vy Updated according to your comments. Kindly help to approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vy commented on a change in pull request #588:
URL: https://github.com/apache/logging-log4j2/pull/588#discussion_r731110308
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java
##
@@ -33,4 +45,41 @@ void testCreateManagerName() {
vy commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r731122734
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##
@@ -273,10 +273,11 @@ protected MimeMultipart getMimeMultipa
vy commented on pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#issuecomment-945964115
@romainmoreau, thanks so much for the PR! Would you also mind updating
`changes.xml`, please?
--
This is an automated message from the Apache Git Service.
To respond to the me
vy commented on pull request #587:
URL: https://github.com/apache/logging-log4j2/pull/587#issuecomment-945967507
This PR is superseded by #590.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
vy commented on a change in pull request #590:
URL: https://github.com/apache/logging-log4j2/pull/590#discussion_r731128382
##
File path: src/changes/changes.xml
##
@@ -5450,6 +5450,9 @@
Make sure all application facing log methods use their own FQCN. This
patch
vy merged pull request #590:
URL: https://github.com/apache/logging-log4j2/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
vy commented on pull request #590:
URL: https://github.com/apache/logging-log4j2/pull/590#issuecomment-945970019
Great work @wuqian0808! Thanks so much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
romainmoreau commented on pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#issuecomment-946087235
@vy done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
barrynfleming commented on a change in pull request #588:
URL: https://github.com/apache/logging-log4j2/pull/588#discussion_r731252556
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java
##
@@ -33,4 +45,41 @@ void testCreateManagerName
jvz commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r731254376
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##
@@ -273,10 +273,11 @@ protected MimeMultipart getMimeMultip
garydgregory commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r731293695
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##
@@ -273,10 +273,11 @@ protected MimeMultipart getM
vy commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r731535795
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##
@@ -273,10 +273,11 @@ protected MimeMultipart getMimeMultipa
vy commented on a change in pull request #588:
URL: https://github.com/apache/logging-log4j2/pull/588#discussion_r731538043
##
File path:
log4j-core/src/test/java/org/apache/logging/log4j/core/net/SmtpManagerTest.java
##
@@ -33,4 +45,41 @@ void testCreateManagerName() {
vy merged pull request #588:
URL: https://github.com/apache/logging-log4j2/pull/588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
edwgiz closed pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificat
swebb2066 opened a new pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73
This PR provides a tool for measuring the cost of changes to the Logger and
Hierarchy classes.
I have measured the cost of the std::mutex lock in Hierarchy::isDisabled as
approx 1300 ns.
romainmoreau commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r732218121
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##
@@ -273,10 +273,11 @@ protected MimeMultipart getM
vy commented on pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#issuecomment-947080992
Fantastic work @edwgiz, thanks so much!
One more question: I am a `MANIFEST.MF` noob, is the empty file necessary?
--
This is an automated message from the Apache Git S
vy commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r732216398
##
File path: log4j-maven-plugins/log4j-maven-plugins-shade-transformer/pom.xml
##
@@ -0,0 +1,233 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi=
vy commented on a change in pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589#discussion_r732234714
##
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/net/SmtpManager.java
##
@@ -273,10 +273,11 @@ protected MimeMultipart getMimeMultipa
vy merged pull request #589:
URL: https://github.com/apache/logging-log4j2/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
rgoers commented on a change in pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#discussion_r732242689
##
File path:
log4j-maven-plugins/log4j-maven-plugins-shade-transformer/src/site/markdown/index.md
##
@@ -0,0 +1,81 @@
+
Review comment:
In
edwgiz commented on pull request #2:
URL: https://github.com/apache/logging-log4j-tools/pull/2#issuecomment-947153607
Thanks for positive feedback
Without MANIFEST.MF the build fails
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-jar-plugin:3.2.0:jar (default-jar
3001 - 3100 of 7264 matches
Mail list logo
