schlosna commented on pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-916568200
I would definitely be interested to see benchmark comparisons for before & after. I imagine the results may depend on the distinct number and shape of formatter patterns used in an application, as that [may push C2 to optimize differently for monomorphic, bimorphic, or megamorphic calls](https://shipilev.net/jvm/anatomy-quarks/16-megamorphic-virtual-calls/) and [some of the potential pitfalls of class hierarchy optimizations](https://shipilev.net/blog/2015/black-magic-method-dispatch/#_conclusion) (though logging tends to be a hot path in many apps, so worth the experimentation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
