rm5248 commented on a change in pull request #70:
URL: https://github.com/apache/logging-log4cxx/pull/70#discussion_r708767899



##########
File path: src/site/markdown/threading.md
##########
@@ -88,6 +93,27 @@ call, as there is an internal mutex that is locked and 
unlocked in order to ensu
 only one thread can be started at a time.  Failure to do this may lead to 
deadlock.
 The ThreadUtility::configure method handles this automatically.
 
+### Configuring Thread {#configuring}
+
+To tell Log4cxx what to do by default when starting a new thread, the enum
+[ThreadConfigurationType](@ref log4cxx.helpers.ThreadConfigurationType) may be
+used to configure the library appropriately.  By default, all signals on POSIX
+systems will be blocked to ensure that other threads do not get signals.
+
+To change this default, a simple change to your configuration files may be 
done.
+
+Example with XML configuration:
+```
+<log4j:configuration threadConfiguration="BlockSignalsOnly">

Review comment:
       Changing it to be the not default makes sense to me.  The reasoning 
behind having two examples with the same setting is that the only difference is 
the config file format, you're not changing two things at a time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to