rm5248 commented on pull request #72: URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-922340153
Looks good to me, but I agree with Thorsten that at least some documentation is needed(currently, the documentation for the conversion characters is in the documentation for the `PatternLayout` class). There are a few errors on Windows(you missed a few LOG4CXX_STR macros on string constants). Also, a unit test would be good to verify that it works correctly. There are already some tests in patternlayouttest.cpp that you can add to. `test1` in that file is probably the easiest to think about - there needs to be a (known-good) file in the witness/ folder that is compared to the given output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
