carterkozak commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713390780



##########
File path: 
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/LogEventFactory.java
##########
@@ -28,8 +28,21 @@
 /**
  *
  */
-public interface LogEventFactory {
+public interface LogEventFactory extends LocationAwareLogEventFactory {

Review comment:
       @rgoers I'd appreciate your input on this part of the change. Now that 
we're using java 8 we can simplify call-sites to invoke the location-aware 
implementation. It's possible though unlikely that implementations could exist 
specifically to avoid capturing location information, but our logger configs 
support configuring that directly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to