carterkozak commented on pull request #573: URL: https://github.com/apache/logging-log4j2/pull/573#issuecomment-924095311
Sorry, Ralph. I've updated this branch with a fix. I'm going to PR something into the release branch separately to improve messaging/behavior in that case because it's a little spooky. `.core.appender.rolling.PatternProcessor` parses patterns and executes (simplified): ```java List<PatternConverter> parsed = ...; ArrayPatternConverter[] converters = parsed.toArray(new ArrayPatternConverter[0]); ``` Calling `toArray(subtype)` succeeds based on runtime type info, however it requires all subtypes to implement ArrrayPatternConverter. I think we should either: 1. Fail loudly and eagerly with an error message that states the ArrayPatternConverter requirement and the type of the invalid converter 2. Allow non-array converters, but pass a null value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
