rm5248 commented on a change in pull request #70:
URL: https://github.com/apache/logging-log4cxx/pull/70#discussion_r708766428
##########
File path: src/main/cpp/domconfigurator.cpp
##########
@@ -1035,6 +1037,19 @@ void DOMConfigurator::parse(
MessageBufferUseStaticStream();
}
+ LogString threadSignalValue = subst(getAttribute(utf8Decoder, element,
THREAD_TYPE_ATTR));
+ if( !threadSignalValue.empty() && threadSignalValue != NuLL ){
Review comment:
yeah that's probably a good idea - it looked odd to me too at first, and
then I realized it is to avoid conflicts with the NULL macro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
