vy commented on pull request #584: URL: https://github.com/apache/logging-log4j2/pull/584#issuecomment-924330636
Thanks so much for the contribution @wx930910! Mocking is definitely a better approach, since it allows (backward-compatible) evolution of `StatusListener` without breaking tests. Not to mention that the intent is clearer as well. Regarding the implementation, I think I would prefer a `verify(listener, never())` finalized with a `verifyNoMoreInteractions()`. If you would be kind enough to update your PR, I will be glad to merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
