rm5248 commented on pull request #72: URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-922464745
> > There are a few errors on Windows(you missed a few LOG4CXX_STR macros on string constants). > > Sorry, I don't figure it out. Could you give me a hint? > You can see the build output here: https://github.com/apache/logging-log4cxx/pull/72/checks?check_run_id=3641130796#step:7:120 An example: https://github.com/apache/logging-log4cxx/pull/72/files#diff-01f067a98edee49220add01cefc76be9ffd6d17579273bc6dced2fcd0b754c25R53 Both format functions use raw string literals( `toAppendTo.append("STRING")`), that needs to be wrapped in LOG4CXX_STR to compile on Windows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
