carterkozak commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r706235288



##########
File path: 
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/LevelPatternConverter.java
##########
@@ -123,7 +120,7 @@ private static String left(final Level level, final int 
length) {
      */
     @Override
     public void format(final LogEvent event, final StringBuilder output) {
-        output.append(levelMap == null ? event.getLevel().toString() : 
levelMap.get(event.getLevel()));
+

Review comment:
       This method should be removed, it's effectively abstract but moving the 
base class from final -> abstract upset revapi.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to