garydgregory commented on a change in pull request #573:
URL: https://github.com/apache/logging-log4j2/pull/573#discussion_r713151635
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java
##########
@@ -669,20 +668,20 @@ private int finalizeConverter(final char c, final String
pattern, final int star
msg.append("] starting at position ");
}
- msg.append(Integer.toString(i));
+ msg.append(i);
msg.append(" in conversion pattern.");
Review comment:
I do not think we should hide boxing and unboxing if we are making all
of these performance based changes. I would think we would want to see as much
of the mechanics as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
