Re: [PR] Compute facets while collecting [lucene]

mikemccand commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2302206543 > Perhaps this is something we'd want to fix for Lucene 10 if it requires breaking changes? +1, thanks @javanna and @gsmiller. -- This is an automated message from the Apache

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1724471801 ## lucene/core/src/java/org/apache/lucene/search/CollectorOwner.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2297766370 Thanks @javanna for raising this. I agree with trying to figure out how to shrink this API surface area in `IndexSearcher` back down prior to the 10.0 release. I don't have any immediat

Re: [PR] Compute facets while collecting [lucene]

javanna commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2297566037 Hey all, sorry about my late comment, I noticed the `IndexSearcher` changes, the additional search method that takes a `CollectorOwner` and the new `CollectorOwner` abstraction. It looks

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289348515 OK I pushed a small change (#13656) to `IndexSearcher` that reverts the "common" (i.e., non-drill-sideways) code-path back to what it was before this faceting change. It appears to reve

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289299245 Thanks @epotyom ! I think I've isolated the change that's causing the regression and I've put up a PR (#13656) to temporarily fix it. It just reverts the IndexSearcher changes back to w

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289274913 @gsmiller oh you are right, it was wikimedium10**k**. Results for `wikimediumall` confirm that this PR causes the regression. ``` TaskQPS baseline

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289239609 @epotyom just to confirm, are you using `wikimedium10k` or `wikimedium10m`? As another check, I reverted out the changes to IndexSearcher and DrillSideways/DrillSidewaysQuery (so

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289194440 @gsmiller my results for `wikimedium10k` are quite different, but it might be that something is wrong with my setup, double-checking; I'm also running tests for `wikimediumall` but they

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289194124 After looking through the change for possible ways it could impact non-faceting tasks, the only thing that jumped out to me was the synchronization of the collector list in `CollectorOw

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289109976 I was already setup to run benchmarks so I did a quick run with `wikimedium10m` that isolated this change. The results are a bit surprising. @epotyom I'll be curious if you reproduce si

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2288910722 @mikemccand , @jpountz thanks for heads up! I'm running local benchmarks now to check if it is related to this change. -- This is an automated message from the Apache Git Service. To r

Re: [PR] Compute facets while collecting [lucene]

mikemccand commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2288769876 [Term](https://home.apache.org/~mikemccand/lucenebench/Term.html) as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Compute facets while collecting [lucene]

jpountz commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2288723938 [SloppyPhrase](https://home.apache.org/~mikemccand/lucenebench/SloppyPhrase.html) and [SpanNear](https://home.apache.org/~mikemccand/lucenebench/SpanNear.html) had a noticeable slowdown

Re: [PR] Compute facets while collecting [lucene]

mikemccand commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2288666763 Hmm is it possible the `CollectorOwner` change here somehow led to [this surprising nightly benchmark performance drop](https://home.apache.org/~mikemccand/lucenebench/CombinedHighMed

Re: [PR] Compute facets while collecting [lucene]

gsmiller merged PR #13568: URL: https://github.com/apache/lucene/pull/13568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1712617910 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1712610080 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/misc/LongValueFacetCutter.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2278854633 @epotyom I looked over the recent changes and went through the unresolved comments. I don't think there's anything blocking at this point from my point of view. @mikemccand do you have

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1712251401 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/FacetRecorder.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1712250405 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/CandidateSetOrdinalIterator.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1712247433 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/FacetFieldCollectorManager.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1712245609 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/DoubleRangeFacetCutter.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1712245084 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1712226750 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java: ## @@ -45,58 +45,26 @@ class DrillSidewaysQuery extends Query { final Query baseQuery;

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2278257636 @stefanvodita , @gsmiller , @mikemccand just wanted to let you know that I think I addressed all existing comments, and I marked as resolved the ones that don't seem to need follow ups.

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711693361 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/FacetFieldCollectorManager.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711547954 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/OrdinalGetter.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Compute facets while collecting [lucene]

stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711388569 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/LongAggregationsFacetRecorder.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711382272 ## lucene/core/src/java/org/apache/lucene/search/CollectorOwner.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] Compute facets while collecting [lucene]

stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711380093 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/OverlappingLongRangeFacetCutter.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Compute facets while collecting [lucene]

stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711379107 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/CountFacetRecorder.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Compute facets while collecting [lucene]

stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711375034 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java: ## @@ -45,58 +45,26 @@ class DrillSidewaysQuery extends Query { final Query baseQue

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711353146 ## lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/SandboxFacetTestCase.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711347682 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/misc/LongValueFacetCutter.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711348674 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinal_iterators/CandidateSetOrdinalIterator.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711338640 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/LongAggregationsFacetRecorder.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711213814 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/RangeOrdLabelBiMap.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711205288 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/RangeOrdLabelBiMap.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711199728 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,431 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711194467 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/ExclusiveLongRangeFacetCutter.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711174092 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/OverlappingLongRangeFacetCutter.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711163320 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,431 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710374307 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/taxonomy/TaxonomyChildrenOrdinalIterator.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710371930 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710365017 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/FacetFieldLeafCollector.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710360090 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/FacetFieldLeafCollector.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710358112 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/CountFacetRecorder.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710346627 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/FacetRecorder.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710344889 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/FacetRecorder.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710343109 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/abstracts/OrdinalIterator.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710338323 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FacetLabel.java: ## @@ -178,6 +178,11 @@ public FacetLabel subpath(final int length) { } } + /** G

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710320207 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java: ## @@ -45,58 +45,26 @@ class DrillSidewaysQuery extends Query { final Query baseQuery;

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710320207 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java: ## @@ -45,58 +45,26 @@ class DrillSidewaysQuery extends Query { final Query baseQuery;

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710309544 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710300104 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/LongValueFacetCutter.java: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710295193 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/LongValueFacetCutter.java: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710265556 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java: ## @@ -349,45 +344,142 @@ private DrillDownQuery getDrillDownQuery( public ConcurrentDrillSide

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1710246000 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java: ## @@ -349,45 +344,142 @@ private DrillDownQuery getDrillDownQuery( public ConcurrentDrillSide

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709992304 ## lucene/CHANGES.txt: ## @@ -133,6 +142,8 @@ New Features DocValuesSkipper abstraction. A new flag is added to FieldType.java that configures whether to create

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709975382 ## lucene/core/src/java/org/apache/lucene/search/CollectorOwner.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709952530 ## lucene/sandbox/src/java/module-info.java: ## @@ -19,13 +19,21 @@ module org.apache.lucene.sandbox { requires org.apache.lucene.core; requires org.apache.luce

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709932857 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/DoubleRangeFacetCutter.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709932857 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/DoubleRangeFacetCutter.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709835247 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeNode.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709853131 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/OverlappingLongRangeFacetCutter.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709770635 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709713833 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709691392 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Compute facets while collecting [lucene]

stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709557365 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java: ## @@ -45,58 +45,26 @@ class DrillSidewaysQuery extends Query { final Query baseQue

Re: [PR] Compute facets while collecting [lucene]

mikemccand commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1698434531 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/LongValueFacetCutter.java: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1709023544 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1707996827 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/IntervalTracker.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1707976141 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1707964637 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/package-info.java: ## @@ -0,0 +1,18 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1707953948 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/FacetRecorder.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1695329026 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/FacetFieldCollectorManager.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1695319115 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/OrdinalGetter.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1695316438 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/CandidateSetOrdinalIterator.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1695312400 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/FacetRecorder.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1695011732 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java: ## @@ -398,130 +490,56 @@ private ConcurrentDrillSidewaysResult searchSequentially( }

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1694979476 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1694907952 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/FacetFieldCollectorManager.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1694819821 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/misc/LongValueFacetCutter.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Compute facets while collecting [lucene]

stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1694596250 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Compute facets while collecting [lucene]

stefanvodita commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1694595387 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/OrdToComparable.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1694003960 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/OrdinalGetter.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693975540 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/CandidateSetOrdinalIterator.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693975482 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/FacetRecorder.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693661698 ## lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java: ## @@ -398,130 +490,56 @@ private ConcurrentDrillSidewaysResult searchSequentially( }

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693303944 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/RangeFacetCutter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693303123 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ComparableUtils.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693302149 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/OrdToComparable.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693301489 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/OrdinalGetter.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693224624 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/CandidateSetOrdinalIterator.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693220989 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/CandidateSetOrdinalIterator.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693218171 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/misc/LongValueFacetCutter.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693206893 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/CountFacetRecorder.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Compute facets while collecting [lucene]

epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693203171 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/RangeFacetCutter.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Compute facets while collecting [lucene]

gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693205018 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/recorders/FacetRecorder.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

  1   2   3   >