gsmiller commented on PR #13568:
URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289239609
@epotyom just to confirm, are you using `wikimedium10k` or `wikimedium10m`?
As another check, I reverted out the changes to IndexSearcher and
DrillSideways/DrillSidewaysQuery (so nothing is actually using CollectorOwner)
and benchmarked again, which showed no change (seems like an additional
confirmation that something in the IndexSearcher change is causing the
regression)
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
AndHighHigh 225.16 (6.1%) 217.69
(8.5%) -3.3% ( -16% - 12%) 0.156
BrowseDayOfYearSSDVFacets 11.17 (18.2%) 10.87
(13.9%) -2.7% ( -29% - 35%) 0.601
BrowseDateSSDVFacets 2.19 (19.4%) 2.13
(18.8%) -2.6% ( -34% - 44%) 0.664
OrHighHigh 201.22 (5.0%) 198.72
(4.7%) -1.2% ( -10% - 8%) 0.417
HighSpanNear 37.17 (4.6%) 36.83
(4.2%) -0.9% ( -9% - 8%) 0.504
AndHighMed 387.99 (4.0%) 384.72
(3.1%) -0.8% ( -7% - 6%) 0.461
LowSpanNear 156.07 (9.6%) 155.19
(10.7%) -0.6% ( -19% - 21%) 0.860
Respell 51.44 (8.2%) 51.17
(8.0%) -0.5% ( -15% - 17%) 0.841
HighTermTitleSort 114.14 (4.2%) 113.96
(4.5%) -0.2% ( -8% - 8%) 0.911
MedTermDayTaxoFacets 25.86 (7.3%) 25.85
(5.2%) -0.0% ( -11% - 13%) 0.984
MedIntervalsOrdered 75.74 (3.4%) 75.78
(3.6%) 0.1% ( -6% - 7%) 0.960
MedSpanNear 68.28 (3.2%) 68.32
(3.9%) 0.1% ( -6% - 7%) 0.954
LowIntervalsOrdered 200.45 (3.1%) 200.73
(3.9%) 0.1% ( -6% - 7%) 0.900
AndHighHighDayTaxoFacets 25.84 (7.3%) 25.88
(6.6%) 0.2% ( -12% - 15%) 0.943
HighTermDayOfYearSort 306.66 (6.9%) 307.52
(8.4%) 0.3% ( -14% - 16%) 0.908
HighPhrase 101.89 (2.9%) 102.33
(3.6%) 0.4% ( -5% - 7%) 0.672
OrNotHighLow 1199.84 (3.8%) 1207.82
(4.2%) 0.7% ( -7% - 8%) 0.599
OrHighNotHigh 295.78 (7.0%) 297.91
(8.0%) 0.7% ( -13% - 16%) 0.762
OrHighNotLow 513.94 (7.2%) 517.70
(10.4%) 0.7% ( -15% - 19%) 0.796
LowPhrase 43.34 (6.0%) 43.69
(5.8%) 0.8% ( -10% - 13%) 0.664
OrHighMed 437.90 (2.8%) 441.57
(3.2%) 0.8% ( -5% - 7%) 0.379
HighIntervalsOrdered 46.13 (5.6%) 46.57
(5.7%) 1.0% ( -9% - 13%) 0.588
HighTermMonthSort 1059.70 (4.2%) 1070.83
(4.6%) 1.1% ( -7% - 10%) 0.452
MedPhrase 86.75 (3.5%) 87.71
(4.4%) 1.1% ( -6% - 9%) 0.373
Wildcard 538.29 (5.2%) 544.52
(6.9%) 1.2% ( -10% - 13%) 0.548
MedTerm 584.28 (4.0%) 591.18
(5.9%) 1.2% ( -8% - 11%) 0.459
OrHighLow 477.35 (3.8%) 483.20
(4.0%) 1.2% ( -6% - 9%) 0.320
LowTerm 925.34 (5.1%) 938.49
(4.5%) 1.4% ( -7% - 11%) 0.353
PKLookup 132.45 (10.2%) 134.45
(12.8%) 1.5% ( -19% - 27%) 0.681
HighTerm 420.18 (7.4%) 427.12
(8.8%) 1.7% ( -13% - 19%) 0.522
AndHighLow 1337.71 (5.3%) 1359.97
(4.9%) 1.7% ( -8% - 12%) 0.302
OrNotHighMed 323.46 (4.3%) 329.44
(5.0%) 1.8% ( -7% - 11%) 0.209
HighTermTitleBDVSort 15.31 (10.5%) 15.65
(8.9%) 2.2% ( -15% - 24%) 0.469
LowSloppyPhrase 212.91 (2.7%) 217.65
(2.6%) 2.2% ( -2% - 7%) 0.007
OrHighMedDayTaxoFacets 7.45 (5.7%) 7.63
(4.3%) 2.5% ( -7% - 13%) 0.122
IntNRQ 80.63 (9.9%) 82.77
(7.4%) 2.7% ( -13% - 22%) 0.338
AndHighMedDayTaxoFacets 101.24 (8.0%) 104.11
(9.2%) 2.8% ( -13% - 21%) 0.299
MedSloppyPhrase 105.12 (3.7%) 108.30
(3.5%) 3.0% ( -3% - 10%) 0.007
Fuzzy2 55.64 (8.6%) 57.63
(8.6%) 3.6% ( -12% - 22%) 0.189
Fuzzy1 66.77 (10.6%) 69.30
(7.4%) 3.8% ( -12% - 24%) 0.189
OrNotHighHigh 199.05 (7.7%) 206.60
(8.0%) 3.8% ( -11% - 21%) 0.127
BrowseMonthSSDVFacets 11.67 (19.6%) 12.12
(17.0%) 3.9% ( -27% - 50%) 0.504
HighSloppyPhrase 60.07 (5.5%) 62.47
(5.2%) 4.0% ( -6% - 15%) 0.018
OrHighNotMed 413.96 (7.0%) 430.85
(8.1%) 4.1% ( -10% - 20%) 0.087
BrowseRandomLabelSSDVFacets 7.80 (11.2%) 8.12
(10.7%) 4.1% ( -16% - 29%) 0.235
BrowseMonthTaxoFacets 22.54 (32.7%) 23.94
(29.4%) 6.2% ( -42% - 101%) 0.528
TermDTSort 201.43 (8.9%) 216.02
(11.6%) 7.2% ( -12% - 30%) 0.026
BrowseRandomLabelTaxoFacets 14.38 (29.9%) 15.45
(21.6%) 7.5% ( -33% - 84%) 0.363
Prefix3 527.93 (15.0%) 574.70
(13.1%) 8.9% ( -16% - 43%) 0.047
BrowseDateTaxoFacets 20.97 (34.9%) 23.04
(26.8%) 9.9% ( -38% - 109%) 0.316
BrowseDayOfYearTaxoFacets 21.68 (34.2%) 23.85
(26.5%) 10.0% ( -37% - 107%) 0.301
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
