gsmiller commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289348515
OK I pushed a small change (#13656) to `IndexSearcher` that reverts the "common" (i.e., non-drill-sideways) code-path back to what it was before this faceting change. It appears to reverse the regressions when I measure with luceneutil. I'll check the nightly benchmark runs tomorrow to see if they recover as I expect them to. In parallel, I'll keep working with @epotyom to figure out what the actual root cause of the regression is and see if we can put a more elegant fix in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
