epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1709952530
##########
lucene/sandbox/src/java/module-info.java:
##########
@@ -19,13 +19,21 @@
module org.apache.lucene.sandbox {
requires org.apache.lucene.core;
requires org.apache.lucene.queries;
+ requires org.apache.lucene.facet;
exports org.apache.lucene.payloads;
exports org.apache.lucene.sandbox.codecs.idversion;
exports org.apache.lucene.sandbox.document;
exports org.apache.lucene.sandbox.queries;
exports org.apache.lucene.sandbox.search;
exports org.apache.lucene.sandbox.index;
+ exports org.apache.lucene.sandbox.facet;
Review Comment:
@stefanvodita also suggested it before, I've checked some other classes in
sandbox module and they don't always have `@lucene.experimental`. That being
said, I agree that it's easy to do, and since two reviewers already have said
it's a good ideal I'll do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
