gsmiller commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289299245
Thanks @epotyom ! I think I've isolated the change that's causing the regression and I've put up a PR (#13656) to temporarily fix it. It just reverts the IndexSearcher changes back to what they were before this faceting work and adds the new functionality to IndexSearcher needed by faceting as a net-new piece of code (although with obvious duplication). I'm running benchmarks now to confirm the issue is gone with that PR. I think we should merge that as a next step, confirm the nightly runs recover, and then keep debugging to figure out what the issue is so we can remove the code duplication in IndexSearcher as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
