epotyom commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289274913
@gsmiller oh you are right, it was wikimedium10**k**. Results for `wikimediumall` confirm that this PR causes the regression. ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value HighTerm 477.61 (7.9%) 383.98 (6.9%) -19.6% ( -31% - -5%) 0.000 MedTerm 575.04 (6.3%) 499.77 (4.9%) -13.1% ( -22% - -1%) 0.000 LowTerm 591.78 (4.3%) 526.82 (2.9%) -11.0% ( -17% - -3%) 0.000 MedSloppyPhrase 39.18 (3.3%) 34.96 (2.2%) -10.8% ( -15% - -5%) 0.000 BrowseDateSSDVFacets 0.47 (15.8%) 0.44 (18.5%) -6.6% ( -35% - 32%) 0.225 HighSpanNear 27.58 (1.4%) 26.17 (1.6%) -5.1% ( -8% - -2%) 0.000 IntNRQ 45.67 (14.8%) 43.42 (15.8%) -4.9% ( -30% - 30%) 0.308 BrowseMonthSSDVFacets 2.80 (6.4%) 2.69 (6.4%) -4.2% ( -16% - 9%) 0.037 OrHighHigh 71.84 (10.4%) 69.00 (9.5%) -3.9% ( -21% - 17%) 0.211 BrowseDateTaxoFacets 1.65 (9.7%) 1.59 (0.6%) -3.3% ( -12% - 7%) 0.128 BrowseDayOfYearTaxoFacets 1.66 (9.5%) 1.61 (0.7%) -3.2% ( -12% - 7%) 0.133 BrowseDayOfYearSSDVFacets 2.71 (5.9%) 2.63 (5.0%) -2.9% ( -13% - 8%) 0.092 LowSloppyPhrase 74.15 (4.0%) 72.12 (2.9%) -2.7% ( -9% - 4%) 0.013 BrowseRandomLabelSSDVFacets 1.66 (4.7%) 1.62 (4.5%) -2.4% ( -11% - 7%) 0.097 AndHighMed 126.04 (3.9%) 123.36 (4.3%) -2.1% ( -9% - 6%) 0.101 OrHighLow 525.51 (2.9%) 518.22 (3.9%) -1.4% ( -8% - 5%) 0.205 Prefix3 337.80 (4.0%) 333.34 (3.4%) -1.3% ( -8% - 6%) 0.260 HighPhrase 151.46 (3.9%) 149.55 (3.5%) -1.3% ( -8% - 6%) 0.280 LowSpanNear 205.05 (1.5%) 202.79 (1.9%) -1.1% ( -4% - 2%) 0.041 OrHighMed 208.35 (3.7%) 206.08 (3.6%) -1.1% ( -8% - 6%) 0.344 LowPhrase 203.49 (2.3%) 201.61 (2.3%) -0.9% ( -5% - 3%) 0.206 MedPhrase 211.90 (3.5%) 210.17 (2.7%) -0.8% ( -6% - 5%) 0.411 BrowseRandomLabelTaxoFacets 1.29 (6.9%) 1.28 (3.6%) -0.8% ( -10% - 10%) 0.661 HighSloppyPhrase 1.26 (5.7%) 1.25 (3.4%) -0.6% ( -9% - 9%) 0.689 HighTermDayOfYearSort 309.55 (4.6%) 308.20 (3.3%) -0.4% ( -8% - 7%) 0.731 AndHighHigh 60.26 (5.0%) 60.02 (6.0%) -0.4% ( -10% - 11%) 0.819 HighTermTitleSort 53.61 (2.2%) 53.42 (3.1%) -0.4% ( -5% - 5%) 0.673 MedSpanNear 78.07 (1.0%) 77.85 (1.3%) -0.3% ( -2% - 2%) 0.458 AndHighLow 861.54 (3.1%) 859.71 (4.1%) -0.2% ( -7% - 7%) 0.853 Fuzzy2 59.87 (2.1%) 59.76 (1.9%) -0.2% ( -4% - 3%) 0.772 AndHighHighDayTaxoFacets 8.48 (1.9%) 8.47 (3.6%) -0.1% ( -5% - 5%) 0.916 MedTermDayTaxoFacets 13.17 (1.9%) 13.17 (4.8%) 0.0% ( -6% - 6%) 0.996 Wildcard 324.45 (4.6%) 324.68 (4.3%) 0.1% ( -8% - 9%) 0.960 MedIntervalsOrdered 97.68 (5.1%) 97.76 (5.5%) 0.1% ( -10% - 11%) 0.963 HighTermMonthSort 1043.14 (6.6%) 1045.21 (5.3%) 0.2% ( -10% - 12%) 0.916 HighIntervalsOrdered 23.55 (5.6%) 23.60 (6.3%) 0.2% ( -11% - 12%) 0.908 HighTermTitleBDVSort 20.48 (2.7%) 20.52 (2.6%) 0.2% ( -4% - 5%) 0.793 AndHighMedDayTaxoFacets 36.77 (1.8%) 36.89 (2.2%) 0.3% ( -3% - 4%) 0.640 Fuzzy1 66.55 (2.4%) 66.77 (2.1%) 0.3% ( -4% - 4%) 0.642 Respell 53.88 (1.9%) 54.08 (2.3%) 0.4% ( -3% - 4%) 0.575 PKLookup 132.96 (3.1%) 133.48 (2.4%) 0.4% ( -4% - 6%) 0.651 OrHighMedDayTaxoFacets 2.79 (6.1%) 2.80 (6.9%) 0.6% ( -11% - 14%) 0.785 OrNotHighLow 967.21 (3.7%) 973.74 (2.8%) 0.7% ( -5% - 7%) 0.517 OrHighNotLow 353.90 (7.2%) 356.37 (6.3%) 0.7% ( -11% - 15%) 0.744 LowIntervalsOrdered 17.05 (2.7%) 17.17 (3.1%) 0.7% ( -4% - 6%) 0.436 BrowseMonthTaxoFacets 1.86 (8.6%) 1.88 (7.7%) 1.1% ( -13% - 19%) 0.661 OrHighNotMed 383.12 (7.2%) 392.02 (4.0%) 2.3% ( -8% - 14%) 0.206 TermDTSort 100.54 (4.4%) 103.07 (3.1%) 2.5% ( -4% - 10%) 0.035 OrHighNotHigh 213.95 (7.4%) 220.28 (4.6%) 3.0% ( -8% - 16%) 0.127 OrNotHighHigh 227.97 (7.4%) 240.46 (4.4%) 5.5% ( -5% - 18%) 0.004 OrNotHighMed 284.57 (4.2%) 307.35 (4.8%) 8.0% ( -1% - 17%) 0.000 ``` JFR diff image, not sure what to make of it yet:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org