javanna commented on PR #13568: URL: https://github.com/apache/lucene/pull/13568#issuecomment-2297566037
Hey all, sorry about my late comment, I noticed the `IndexSearcher` changes, the additional search method that takes a `CollectorOwner` and the new `CollectorOwner` abstraction. It looks like it works around some limitations of the current `CollectorManager` design which perhaps could be worked around by modifying `CollectorManager` itself, instead of adding a new abstraction. To me, either this is a specific drill sideways requirement that does not leak out to `IndexSearcher`, or it is a more general requirement that should require adapting `CollectorManager` as opposed to increasing the surface of `IndexSearcher` to support both a `CollectorOwner` as well as a `CollectorManager`. Perhaps this is something we'd want to fix for Lucene 10 if it requires breaking changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
