epotyom commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1711382272
########## lucene/core/src/java/org/apache/lucene/search/CollectorOwner.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.List; + +/** + * Like {@link CollectorManager}, but it owns the collectors its manager creates. It is convenient + * that clients of the class don't have to worry about keeping the list of collectors, as well as + * about making the collectors type (C) compatible when reduce is called. Instance of this class + * also caches results of {@link CollectorManager#reduce(Collection)}. + * + * <p>Note that instance of this class ignores any {@link Collector} created by {@link + * CollectorManager#newCollector()} directly, not through {@link #newCollector()} + * + * @lucene.experimental + */ +public final class CollectorOwner<C extends Collector, T> { Review Comment: > Ahhh OK thank you for the explanation. I like the new `CollectorOwner` ... I just wish we could somehow iterate `CollectorManager` towards that, or deprecate / phase out `CollectorManager` somehow, or ... I'm not sure how to do that TBH. Changing `CollectorManager` to keep its collectors means that we either have to make it abstract class (which might not be convenient for users) or make sure each implementation keeps a list of its collectors, which adds some code duplication? Alternatively we could rename it to something like `CollectorSource` (similarly to DoubleValues**Source**) or `CollectorSupplier`? Although `reduce` method doesn't seem to fit into Source/Supplier category well. > But it seems worth at least creating an actual issue to track this TODO and see if we can converge at some point? Good point, I'll create an issue when/if this PR is merged, just in case we come up with a better solution as part of this PR later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
