gsmiller commented on code in PR #13568: URL: https://github.com/apache/lucene/pull/13568#discussion_r1693301489
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/ordinals/OrdinalGetter.java: ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.sandbox.facet.ordinals; + +/** Interface to return an ordinal. */ +public interface OrdinalGetter { Review Comment: Ha yeah OK. I'm really hung up on this `OrdinalGetter` :). I think I'm trying to get rid of it because it's really only needed for one thing, which is top-n sorting—and only needed to specify that these comparable instances in the heap can provide their ordinals back. But that's annoying because the top-n implementation already knows the ordinals to begin with (because it's wrapping another ordinal iterator). What if we change the top-n logic to create its own objects in its internal heap that wrap both the comparable instance and the ordinal? Essentially `Pair<Integer, T>`. Then it can just keep track of the ordinals itself and not rely on the comparable instances to provide the ordinals back? I think that's actually a cleaner abstraction anyway and frees up the comparable instances from having to keep track of ordinals (even though the three you have implemented do that, there's nothing that says they should all need to do that right?). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
