epotyom commented on code in PR #13568:
URL: https://github.com/apache/lucene/pull/13568#discussion_r1710338323
##########
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FacetLabel.java:
##########
@@ -178,6 +178,11 @@ public FacetLabel subpath(final int length) {
}
}
+ /** Get the last component. */
+ public String lastComponent() {
+ return components[components.length - 1];
Review Comment:
Done!
##########
lucene/core/src/java/org/apache/lucene/search/DoubleValuesSource.java:
##########
@@ -115,6 +116,69 @@ public final LongValuesSource toLongValuesSource() {
return new LongDoubleValuesSource(this);
}
+ public final LongValuesSource toSortableLongDoubleValuesSource() {
+ return new SortableLongDoubleValuesSource(this);
+ }
+
+ private static class SortableLongDoubleValuesSource extends LongValuesSource
{
+
+ private final DoubleValuesSource inner;
+
+ private SortableLongDoubleValuesSource(DoubleValuesSource inner) {
+ this.inner = inner;
Review Comment:
Done!
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/cutters/ranges/LongRangeFacetCutter.java:
##########
@@ -0,0 +1,354 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.sandbox.facet.cutters.ranges;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Comparator;
+import java.util.List;
+import org.apache.lucene.facet.MultiLongValues;
+import org.apache.lucene.facet.MultiLongValuesSource;
+import org.apache.lucene.facet.range.LongRange;
+import org.apache.lucene.sandbox.facet.cutters.FacetCutter;
+import org.apache.lucene.sandbox.facet.cutters.LeafFacetCutter;
+import org.apache.lucene.search.LongValues;
+import org.apache.lucene.search.LongValuesSource;
+
+/** {@link FacetCutter} for ranges of long values. It's based on
LongRangeCounter class. */
+public abstract class LongRangeFacetCutter implements FacetCutter {
+
+ final MultiLongValuesSource valuesSource;
+ final LongValuesSource
+ singleValues; // TODO: refactor - weird that we have both multi and
single here.
Review Comment:
I blame spotless, fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
