epotyom commented on PR #13568:
URL: https://github.com/apache/lucene/pull/13568#issuecomment-2289194440
@gsmiller my results for `wikimedium10k` are quite different, but it might
be that something is wrong with my setup, double-checking; I'm also running
tests for `wikimediumall` but they are not done yet as I've never built index
for the new Lucene912 codec.
The change in IndexSearcher#search and CollectorOwner that might be related
is that `CollectorOwner` keeps `Collector`s in a synchronised list, which I
think can cause noticeable performance impact it the query exec itself is very
fast? I'll look at JFR files too see if that's the case when the test is done.
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
BrowseDateSSDVFacets 1163.38 (17.2%) 1119.67
(20.7%) -3.8% ( -35% - 41%) 0.532
HighSpanNear 497.58 (10.7%) 479.03
(14.4%) -3.7% ( -26% - 23%) 0.353
Fuzzy1 298.47 (8.2%) 287.84
(6.8%) -3.6% ( -17% - 12%) 0.133
BrowseMonthTaxoFacets 1806.93 (8.7%) 1750.34
(8.1%) -3.1% ( -18% - 14%) 0.238
BrowseRandomLabelSSDVFacets 694.14 (11.0%) 683.07
(8.7%) -1.6% ( -19% - 20%) 0.610
MedIntervalsOrdered 1891.59 (7.1%) 1870.17
(5.2%) -1.1% ( -12% - 12%) 0.565
Respell 294.59 (9.6%) 291.84
(7.5%) -0.9% ( -16% - 17%) 0.732
BrowseDateTaxoFacets 1983.50 (8.3%) 1964.99
(8.7%) -0.9% ( -16% - 17%) 0.730
HighPhrase 504.41 (12.6%) 499.78
(10.0%) -0.9% ( -20% - 24%) 0.799
BrowseDayOfYearSSDVFacets 2187.97 (20.3%) 2168.49
(16.7%) -0.9% ( -31% - 45%) 0.880
LowPhrase 1307.00 (8.0%) 1301.30
(8.4%) -0.4% ( -15% - 17%) 0.867
AndHighLow 1332.73 (7.3%) 1328.35
(9.3%) -0.3% ( -15% - 17%) 0.901
HighTerm 809.67 (12.6%) 808.34
(8.7%) -0.2% ( -19% - 24%) 0.962
OrHighMed 802.15 (8.0%) 800.86
(7.8%) -0.2% ( -14% - 16%) 0.948
Prefix3 564.39 (8.5%) 563.52
(12.7%) -0.2% ( -19% - 22%) 0.964
BrowseMonthSSDVFacets 2178.32 (20.0%) 2183.69
(15.7%) 0.2% ( -29% - 45%) 0.965
AndHighMed 921.59 (8.7%) 925.68
(9.8%) 0.4% ( -16% - 20%) 0.880
MedSloppyPhrase 409.88 (14.8%) 411.84
(14.5%) 0.5% ( -25% - 34%) 0.918
OrHighHigh 460.88 (12.6%) 464.13
(10.4%) 0.7% ( -19% - 27%) 0.847
Wildcard 387.27 (10.3%) 391.08
(8.2%) 1.0% ( -15% - 21%) 0.739
MedPhrase 839.57 (14.4%) 848.45
(7.9%) 1.1% ( -18% - 27%) 0.773
AndHighHigh 507.56 (10.7%) 513.02
(11.8%) 1.1% ( -19% - 26%) 0.763
BrowseDayOfYearTaxoFacets 1833.28 (7.8%) 1859.33
(6.4%) 1.4% ( -11% - 16%) 0.528
OrHighLow 710.49 (11.1%) 720.63
(8.6%) 1.4% ( -16% - 23%) 0.650
MedSpanNear 904.17 (10.6%) 918.71
(9.2%) 1.6% ( -16% - 23%) 0.607
IntNRQ 894.42 (9.9%) 911.12
(9.9%) 1.9% ( -16% - 23%) 0.549
MedTerm 2175.06 (7.6%) 2222.74
(4.8%) 2.2% ( -9% - 15%) 0.278
LowSpanNear 718.73 (13.9%) 734.53
(9.6%) 2.2% ( -18% - 29%) 0.560
Fuzzy2 123.89 (6.3%) 126.72
(6.6%) 2.3% ( -9% - 16%) 0.261
BrowseRandomLabelTaxoFacets 916.56 (6.3%) 938.42
(7.4%) 2.4% ( -10% - 17%) 0.273
LowSloppyPhrase 1118.91 (9.4%) 1167.18
(7.8%) 4.3% ( -11% - 23%) 0.114
HighSloppyPhrase 528.92 (10.6%) 552.04
(11.1%) 4.4% ( -15% - 29%) 0.203
LowIntervalsOrdered 1626.45 (9.7%) 1701.81
(10.5%) 4.6% ( -14% - 27%) 0.148
LowTerm 2339.32 (8.1%) 2457.03
(7.6%) 5.0% ( -9% - 22%) 0.044
HighIntervalsOrdered 683.07 (12.3%) 719.64
(15.7%) 5.4% ( -20% - 38%) 0.231
HighTermMonthSort 859.86 (10.8%) 916.82
(7.6%) 6.6% ( -10% - 28%) 0.025
PKLookup 171.76 (15.8%) 183.62
(17.1%) 6.9% ( -22% - 47%) 0.184
HighTermDayOfYearSort 994.52 (9.1%) 1066.75
(8.3%) 7.3% ( -9% - 27%) 0.008
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
