Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

2024-12-16 Thread via GitHub
nastra commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1886799810 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [I] [Discussion] googletest(gtest) or Catch2 [iceberg-cpp]

2024-12-16 Thread via GitHub
zhjwpku commented on issue #12: URL: https://github.com/apache/iceberg-cpp/issues/12#issuecomment-254560 > No strong opinions from me. I myself gravitate towards gtest just because I have experience on that, but could live with any of them. Yeah, both test frameworks seems capable

Re: [I] how to pass where clause predicate to rewrite_data_files which uses year of a timestamp column [iceberg]

2024-12-16 Thread via GitHub
manuzhang commented on issue #11789: URL: https://github.com/apache/iceberg/issues/11789#issuecomment-2545701955 You may try `glue_catalog.system.years(ts)` (where ts is a `TIMESTAMP` and you may cast your column to it) -- This is an automated message from the Apache Git Service. To respo

Re: [PR] feat: Add RemovePartitionSpecs table update [iceberg-rust]

2024-12-16 Thread via GitHub
c-thiel commented on code in PR #804: URL: https://github.com/apache/iceberg-rust/pull/804#discussion_r1886743717 ## crates/iceberg/src/catalog/mod.rs: ## @@ -446,6 +446,12 @@ pub enum TableUpdate { /// Properties to remove removals: Vec, }, +/// Remov

Re: [PR] feat: Add RemovePartitionSpecs table update [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #804: URL: https://github.com/apache/iceberg-rust/pull/804#discussion_r1886809213 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -740,6 +740,35 @@ impl TableMetadataBuilder { .set_default_partition_spec(Self::LAST_ADDED)

Re: [PR] fix: gurantee the deserialize order of struct is same as the struct type [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #795: URL: https://github.com/apache/iceberg-rust/pull/795#discussion_r1886917197 ## crates/iceberg/src/spec/values.rs: ## @@ -3604,4 +3608,29 @@ mod tests { assert_eq!(result, expected); } + +#[test] +fn test_record_ser_de()

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1886929988 ## crates/iceberg/src/io/file_io.rs: ## @@ -165,7 +175,7 @@ impl FileIOBuilder { /// Fetch the scheme string. /// /// The scheme_str will be empty if it

Re: [I] Failed to read iceberg TPCH generated by snowflake [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on issue #790: URL: https://github.com/apache/iceberg-rust/issues/790#issuecomment-2545804247 @Xuanwo are you running into anything else? Curious to learn if it works :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Azure: Support vended credentials refresh in ADLSFileIO. [iceberg]

2024-12-16 Thread via GitHub
ChaladiMohanVamsi commented on code in PR #11577: URL: https://github.com/apache/iceberg/pull/11577#discussion_r1886935941 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/VendedAdlsCredentialProvider.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] IO Implementation using Go CDK [iceberg-go]

2024-12-16 Thread via GitHub
zeroshade merged PR #176: URL: https://github.com/apache/iceberg-go/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

[PR] build(deps): bump golang.org/x/crypto from 0.30.0 to 0.31.0 [iceberg-go]

2024-12-16 Thread via GitHub
dependabot[bot] opened a new pull request, #230: URL: https://github.com/apache/iceberg-go/pull/230 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.30.0 to 0.31.0. Commits https://github.com/golang/crypto/commit/b4f1988a35dee11ec3e05d6bf3e90b695fbd8909";>b4

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.28.5 to 1.28.6 [iceberg-go]

2024-12-16 Thread via GitHub
dependabot[bot] commented on PR #228: URL: https://github.com/apache/iceberg-go/pull/228#issuecomment-2545967655 Looks like github.com/aws/aws-sdk-go-v2/config is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.28.5 to 1.28.6 [iceberg-go]

2024-12-16 Thread via GitHub
dependabot[bot] closed pull request #228: build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.28.5 to 1.28.6 URL: https://github.com/apache/iceberg-go/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.17.46 to 1.17.47 [iceberg-go]

2024-12-16 Thread via GitHub
dependabot[bot] commented on PR #229: URL: https://github.com/apache/iceberg-go/pull/229#issuecomment-2545967713 Looks like github.com/aws/aws-sdk-go-v2/credentials is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.17.46 to 1.17.47 [iceberg-go]

2024-12-16 Thread via GitHub
dependabot[bot] closed pull request #229: build(deps): bump github.com/aws/aws-sdk-go-v2/credentials from 1.17.46 to 1.17.47 URL: https://github.com/apache/iceberg-go/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] build(deps): bump github.com/pterm/pterm from 0.12.79 to 0.12.80 [iceberg-go]

2024-12-16 Thread via GitHub
dependabot[bot] commented on PR #220: URL: https://github.com/apache/iceberg-go/pull/220#issuecomment-2545967226 Looks like github.com/pterm/pterm is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] build(deps): bump github.com/pterm/pterm from 0.12.79 to 0.12.80 [iceberg-go]

2024-12-16 Thread via GitHub
dependabot[bot] closed pull request #220: build(deps): bump github.com/pterm/pterm from 0.12.79 to 0.12.80 URL: https://github.com/apache/iceberg-go/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] IO Implementation using Go CDK [iceberg-go]

2024-12-16 Thread via GitHub
zeroshade closed pull request #111: IO Implementation using Go CDK URL: https://github.com/apache/iceberg-go/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] IO Implementation using Go CDK [iceberg-go]

2024-12-16 Thread via GitHub
zeroshade commented on PR #111: URL: https://github.com/apache/iceberg-go/pull/111#issuecomment-2545965423 closing in favor of #176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] feat: Add RemovePartitionSpecs table update [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on code in PR #804: URL: https://github.com/apache/iceberg-rust/pull/804#discussion_r1887051354 ## crates/iceberg/src/catalog/mod.rs: ## @@ -446,6 +446,12 @@ pub enum TableUpdate { /// Properties to remove removals: Vec, }, +/// Remove

Re: [PR] fix: gurantee the deserialize order of struct is same as the struct type [iceberg-rust]

2024-12-16 Thread via GitHub
ZENOTME commented on code in PR #795: URL: https://github.com/apache/iceberg-rust/pull/795#discussion_r1887057758 ## crates/iceberg/src/spec/values.rs: ## @@ -3604,4 +3608,29 @@ mod tests { assert_eq!(result, expected); } + +#[test] +fn test_record_ser_de

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1887055534 ## crates/iceberg/src/io/file_io.rs: ## @@ -165,7 +175,7 @@ impl FileIOBuilder { /// Fetch the scheme string. /// /// The scheme_str will be empty if i

Re: [PR] feat: TableMetadata Statistic Files [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo merged PR #799: URL: https://github.com/apache/iceberg-rust/pull/799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [I] Tracking issues of iceberg rust v0.4.0 Release [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on issue #739: URL: https://github.com/apache/iceberg-rust/issues/739#issuecomment-2545990295 Hi, I personally believe https://github.com/apache/iceberg-rust/pull/795 is not a blocker. Let's proceed with the release and avoid adding more PRs unless we have truly critical is

Re: [PR] API: add hashcode cache in StructType [iceberg]

2024-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11764: URL: https://github.com/apache/iceberg/pull/11764#discussion_r1887057599 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -824,7 +827,10 @@ public boolean equals(Object o) { @Override public int hashCode

Re: [I] Tracking issues of iceberg rust v0.4.0 Release [iceberg-rust]

2024-12-16 Thread via GitHub
ZENOTME commented on issue #739: URL: https://github.com/apache/iceberg-rust/issues/739#issuecomment-2546006235 Both look good to me. According to https://github.com/apache/iceberg-rust/pull/795#discussion_r1884873126, this reorder will not happen if we use in avro format. In this release v

Re: [PR] fix: gurantee the deserialize order of struct is same as the struct type [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on code in PR #795: URL: https://github.com/apache/iceberg-rust/pull/795#discussion_r1887077718 ## crates/iceberg/src/spec/values.rs: ## @@ -3604,4 +3608,29 @@ mod tests { assert_eq!(result, expected); } + +#[test] +fn test_record_ser_de(

Re: [I] Tracking issues of iceberg rust v0.4.0 Release [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on issue #739: URL: https://github.com/apache/iceberg-rust/issues/739#issuecomment-2546015586 > Both look good to me. According to [#795 (comment)](https://github.com/apache/iceberg-rust/pull/795#discussion_r1884873126), this reorder will not happen if we use in avro format

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/glue from 1.102.0 to 1.104.0 [iceberg-go]

2024-12-16 Thread via GitHub
zeroshade merged PR #227: URL: https://github.com/apache/iceberg-go/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] build(deps): bump golang.org/x/crypto from 0.30.0 to 0.31.0 [iceberg-go]

2024-12-16 Thread via GitHub
zeroshade merged PR #230: URL: https://github.com/apache/iceberg-go/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

[I] Kafka Connect Sporadic Commit Delay [iceberg]

2024-12-16 Thread via GitHub
trolle4 opened a new issue, #11796: URL: https://github.com/apache/iceberg/issues/11796 ### Apache Iceberg version 1.7.1 (latest release) ### Query engine Kafka Connect ### Please describe the bug 🐞 We experience unexplainable large delays on the commits fro

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
raulcd commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1886423651 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] feat: Add RemovePartitionSpecs table update [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on code in PR #804: URL: https://github.com/apache/iceberg-rust/pull/804#discussion_r1886370900 ## crates/iceberg/src/catalog/mod.rs: ## @@ -446,6 +446,12 @@ pub enum TableUpdate { /// Properties to remove removals: Vec, }, +/// Remove

Re: [PR] Fix `Table.scan` to enable case sensitive argument [iceberg-python]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #1423: URL: https://github.com/apache/iceberg-python/pull/1423#discussion_r1886374096 ## pyiceberg/table/__init__.py: ## @@ -268,12 +268,10 @@ def _apply(self, updates: Tuple[TableUpdate, ...], requirements: Tuple[TableRequ return self

Re: [PR] Fix `Table.scan` to enable case sensitive argument [iceberg-python]

2024-12-16 Thread via GitHub
Fokko merged PR #1423: URL: https://github.com/apache/iceberg-python/pull/1423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [I] Tracking issues of iceberg rust v0.4.0 Release [iceberg-rust]

2024-12-16 Thread via GitHub
ZENOTME commented on issue #739: URL: https://github.com/apache/iceberg-rust/issues/739#issuecomment-2545295896 Should we merge #795 before release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Update StrictProjection tests [iceberg-python]

2024-12-16 Thread via GitHub
Fokko merged PR #1422: URL: https://github.com/apache/iceberg-python/pull/1422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Update StrictProjection tests [iceberg-python]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #1422: URL: https://github.com/apache/iceberg-python/pull/1422#discussion_r1886615423 ## tests/test_transforms.py: ## @@ -988,608 +997,367 @@ def _test_projection(lhs: Optional[UnboundPredicate[L]], rhs: Optional[UnboundPr raise ValueError

[PR] Change dot notation in add column documentation to tuple [iceberg-python]

2024-12-16 Thread via GitHub
jeppe-dos opened a new pull request, #1433: URL: https://github.com/apache/iceberg-python/pull/1433 A tuple must be used to make columns in structs as described in add_column: "Because "." may be interpreted as a column path separator or may be used in field names, it is not allowed to a

Re: [I] [Request] Area of Improvements for Documentation [iceberg-python]

2024-12-16 Thread via GitHub
jeppe-dos commented on issue #1407: URL: https://github.com/apache/iceberg-python/issues/1407#issuecomment-2545298787 Yes, I have made a PR: > @jeppe-dos thanks for reporting this! Is this something you would like to contribute? Yes. I have made a pull request here: https://

Re: [PR] Integrate Test Framework [iceberg-cpp]

2024-12-16 Thread via GitHub
zhjwpku commented on PR #13: URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2545327922 > Thanks @zhjwpku ! > > What I would be interested to know is the compile and link times, respectively, for both GTest and Catch2. My experience in Arrow is that GTest's main heade

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-12-16 Thread via GitHub
nastra closed pull request #11587: API, Core: Add formatVersion() to Table URL: https://github.com/apache/iceberg/pull/11587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] API, Core: Add formatVersion() to Table [iceberg]

2024-12-16 Thread via GitHub
nastra commented on PR #11587: URL: https://github.com/apache/iceberg/pull/11587#issuecomment-2545378279 closing this in favor of #11620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] fix: day transform compute [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko merged PR #796: URL: https://github.com/apache/iceberg-rust/pull/796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] fix: day transform compute [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #796: URL: https://github.com/apache/iceberg-rust/pull/796#discussion_r1886675209 ## crates/iceberg/src/transform/temporal.rs: ## @@ -1214,36 +1214,36 @@ mod test { PredicateOperator::LessThan, Datum::timestamp_from

Re: [PR] feat: Add RemovePartitionSpecs table update [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on code in PR #804: URL: https://github.com/apache/iceberg-rust/pull/804#discussion_r1886542369 ## crates/iceberg/src/spec/table_metadata_builder.rs: ## @@ -740,6 +740,32 @@ impl TableMetadataBuilder { .set_default_partition_spec(Self::LAST_ADDED)

Re: [PR] feat: Add RemovePartitionSpecs table update [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on PR #804: URL: https://github.com/apache/iceberg-rust/pull/804#issuecomment-2545121983 When we start implementing this into any reader, we want to check first if the `spec-id`'s that we want to remove is still in use. Similar to the Action that's implemented in Spark by @a

Re: [I] Tracking issues of iceberg rust v0.4.0 Release [iceberg-rust]

2024-12-16 Thread via GitHub
liurenjie1024 commented on issue #739: URL: https://github.com/apache/iceberg-rust/issues/739#issuecomment-2545188196 Should we cut a branch for 0.4.0-rc1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Tracking issues of iceberg rust v0.4.0 Release [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on issue #739: URL: https://github.com/apache/iceberg-rust/issues/739#issuecomment-2545140388 I've cleaned up the milestone, and I think we're good to go 🚀 @sungwy Since we release everything simultaneously, I would highly recommend putting everything in a single tarb

Re: [PR] Core: Add TableUtil to provide access to a table's format version [iceberg]

2024-12-16 Thread via GitHub
nastra merged PR #11620: URL: https://github.com/apache/iceberg/pull/11620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [I] Tracking issues of iceberg rust v0.4.0 Release [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on issue #739: URL: https://github.com/apache/iceberg-rust/issues/739#issuecomment-2545155433 Hi, @sungwy, I prefer to split them into different tarballs since they have different versions. However, I don't have a strong opinion on this. I believe it would be great to relea

Re: [I] [Request] Area of Improvements for Documentation [iceberg-python]

2024-12-16 Thread via GitHub
astrojuanlu commented on issue #1407: URL: https://github.com/apache/iceberg-python/issues/1407#issuecomment-2545241556 > Connection to various catalogs (SQL/Hive/Glue/REST) Just having an authoritative page that lists all supported catalogs would be nice. According to various pages

Re: [I] [Discussion] googletest(gtest) or Catch2 [iceberg-cpp]

2024-12-16 Thread via GitHub
zhjwpku commented on issue #12: URL: https://github.com/apache/iceberg-cpp/issues/12#issuecomment-2545343591 > As I wrote on your PR, my main concern with GTest is compilation times, but I don't know if Catch2 would improve things on this axis. > > One question I have about Catch2 is

Re: [PR] Integrate Test Framework [iceberg-cpp]

2024-12-16 Thread via GitHub
pitrou commented on PR #13: URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2545345091 Thanks for the number @zhjwpku . > As the results shows, catch2 is better at preprocessed file size and compile time, but gtest is better when it comes to link time. I don't think th

Re: [PR] Integrate Test Framework [iceberg-cpp]

2024-12-16 Thread via GitHub
zhjwpku commented on PR #13: URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2545430346 > Thanks for the number @zhjwpku . > > > As the results shows, catch2 is better at preprocessed file size and compile time, but gtest is better when it comes to link time. I don't t

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-16 Thread via GitHub
rdblue commented on code in PR #11785: URL: https://github.com/apache/iceberg/pull/11785#discussion_r1887251904 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException {

Re: [PR] Spec: add variant type [iceberg]

2024-12-16 Thread via GitHub
aihuaxu commented on code in PR #10831: URL: https://github.com/apache/iceberg/pull/10831#discussion_r1887255745 ## format/spec.md: ## @@ -182,6 +182,21 @@ A **`list`** is a collection of values with some element type. The element field A **`map`** is a collection of key-val

Re: [PR] Avro: Support default values for generic data (WIP) [iceberg]

2024-12-16 Thread via GitHub
rdblue commented on code in PR #11786: URL: https://github.com/apache/iceberg/pull/11786#discussion_r1887255824 ## core/src/main/java/org/apache/iceberg/data/avro/PlannedDataReader.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-16 Thread via GitHub
rdblue commented on code in PR #11785: URL: https://github.com/apache/iceberg/pull/11785#discussion_r1887250072 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException {

Re: [PR] Parquet: Implement defaults for generic data [iceberg]

2024-12-16 Thread via GitHub
rdblue commented on code in PR #11785: URL: https://github.com/apache/iceberg/pull/11785#discussion_r1887254859 ## data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java: ## @@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException {

Re: [PR] Core: Add Variant implementation to read serialized objects [iceberg]

2024-12-16 Thread via GitHub
aihuaxu commented on code in PR #11415: URL: https://github.com/apache/iceberg/pull/11415#discussion_r1887235550 ## core/src/main/java/org/apache/iceberg/variants/PrimitiveWrapper.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Fix ParallelIterable deadlock [iceberg]

2024-12-16 Thread via GitHub
osscm commented on code in PR #11781: URL: https://github.com/apache/iceberg/pull/11781#discussion_r1887173077 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -257,17 +257,17 @@ private static class Task implements Supplier>>, Closeable { @Overri

Re: [PR] fix: field id in name mapping should be optional [iceberg-python]

2024-12-16 Thread via GitHub
kevinjqliu commented on code in PR #1426: URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1887165186 ## pyiceberg/table/name_mapping.py: ## Review Comment: In `__str__` https://github.com/apache/iceberg-python/pull/1426/files#diff-55b6571bab1c711ef0bc63

Re: [PR] API: add hashcode cache in StructType [iceberg]

2024-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11764: URL: https://github.com/apache/iceberg/pull/11764#discussion_r1887086788 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -723,6 +723,9 @@ public int hashCode() { public static class StructType extends NestedTy

Re: [I] Tracking issues of iceberg rust v0.4.0 Release [iceberg-rust]

2024-12-16 Thread via GitHub
sungwy commented on issue #739: URL: https://github.com/apache/iceberg-rust/issues/739#issuecomment-2546075233 Sounds good folks. I'll get started with the release. Based on the discussion above, I think we are good to start the release, with the new Python binding included in the sam

Re: [PR] Auth Manager API part 1: HTTPRequest, HTTPHeader [iceberg]

2024-12-16 Thread via GitHub
danielcweeks commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1887274849 ## core/src/main/java/org/apache/iceberg/rest/HTTPHeaders.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] GCP: Add Iceberg Catalog for GCP BigQuery Metastore [iceberg]

2024-12-16 Thread via GitHub
z-kovacs commented on PR #11039: URL: https://github.com/apache/iceberg/pull/11039#issuecomment-2546090559 Hi @hesham-medhat @rdblue - could you give us an update whether this expected to be merged or for some reason this angle has been abandoned by Iceberg / GCP teams? it is a gre

Re: [PR] Core: Add Variant implementation to read serialized objects [iceberg]

2024-12-16 Thread via GitHub
aihuaxu commented on code in PR #11415: URL: https://github.com/apache/iceberg/pull/11415#discussion_r1887235550 ## core/src/main/java/org/apache/iceberg/variants/PrimitiveWrapper.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Core: Add Variant implementation to read serialized objects [iceberg]

2024-12-16 Thread via GitHub
aihuaxu commented on PR #11415: URL: https://github.com/apache/iceberg/pull/11415#issuecomment-2546240889 I think I have a question for PrimitiveWrapper.sizeInBytes() for binary. Otherwise, looks good to me. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Implementing namespace_exists function on the REST Catalog [iceberg-python]

2024-12-16 Thread via GitHub
AhmedNader42 commented on code in PR #1434: URL: https://github.com/apache/iceberg-python/pull/1434#discussion_r1887246806 ## tests/catalog/test_rest.py: ## @@ -681,6 +681,51 @@ def test_update_namespace_properties_200(rest_mock: Mocker) -> None: assert response == Propert

Re: [PR] Auth Manager API part 1: HTTPRequest, HTTPHeader [iceberg]

2024-12-16 Thread via GitHub
danielcweeks commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1887278512 ## core/src/main/java/org/apache/iceberg/rest/HTTPHeaders.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Auth Manager API part 1: HTTPRequest, HTTPHeader [iceberg]

2024-12-16 Thread via GitHub
danielcweeks commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1887276438 ## core/src/main/java/org/apache/iceberg/rest/HTTPHeaders.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Auth Manager API part 1: HTTPRequest, HTTPHeader [iceberg]

2024-12-16 Thread via GitHub
danielcweeks commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1887271043 ## core/src/main/java/org/apache/iceberg/rest/HTTPHeaders.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Auth Manager API part 1: HTTPRequest, HTTPHeader [iceberg]

2024-12-16 Thread via GitHub
danielcweeks commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1887281686 ## core/src/main/java/org/apache/iceberg/rest/HTTPHeaders.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Auth Manager API part 1: HTTPRequest, HTTPHeader [iceberg]

2024-12-16 Thread via GitHub
danielcweeks commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1887285432 ## core/src/main/java/org/apache/iceberg/rest/HTTPHeaders.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] Auth Manager API part 1: HTTPRequest, HTTPHeader [iceberg]

2024-12-16 Thread via GitHub
adutra commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1887288109 ## core/src/main/java/org/apache/iceberg/rest/HTTPHeaders.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] Auth Manager API part 1: HTTPRequest, HTTPHeader [iceberg]

2024-12-16 Thread via GitHub
danielcweeks commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1887289371 ## core/src/test/java/org/apache/iceberg/rest/TestHTTPHeaders.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Deserialize NestedField initial-default and write-default Attributes [iceberg-python]

2024-12-16 Thread via GitHub
paulcichonski commented on code in PR #1432: URL: https://github.com/apache/iceberg-python/pull/1432#discussion_r1887299466 ## pyiceberg/types.py: ## @@ -328,8 +328,8 @@ def __init__( data["type"] = data["type"] if "type" in data else field_type data["required"

[PR] Prep 0.4.0 release [iceberg-rust]

2024-12-16 Thread via GitHub
sungwy opened a new pull request, #809: URL: https://github.com/apache/iceberg-rust/pull/809 - Deprecated functions - Bump version of `iceberg-rust` to 0.4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Prep 0.4.0 release [iceberg-rust]

2024-12-16 Thread via GitHub
sungwy commented on code in PR #809: URL: https://github.com/apache/iceberg-rust/pull/809#discussion_r1887327473 ## README.md: ## @@ -23,8 +23,6 @@ Rust implementation of [Apache Iceberg™](https://iceberg.apache.org/). -Working on [v0.3.0 Release Milestone](https://github.

Re: [I] Tracking issues of iceberg rust v0.4.0 Release [iceberg-rust]

2024-12-16 Thread via GitHub
sungwy commented on issue #739: URL: https://github.com/apache/iceberg-rust/issues/739#issuecomment-2546410059 Let's get this party started~! 🎈 Here's the PR to remove deprecated functions, and bump the version of iceberg-rust for review: https://github.com/apache/iceberg-rust/pull/8

[PR] Spark 3.4: Add view support to SparkSessionCatalog [iceberg]

2024-12-16 Thread via GitHub
nastra opened a new pull request, #11797: URL: https://github.com/apache/iceberg/pull/11797 This backports #11388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Auth Manager API part 1: HTTPRequest, HTTPHeader [iceberg]

2024-12-16 Thread via GitHub
nastra commented on code in PR #11769: URL: https://github.com/apache/iceberg/pull/11769#discussion_r1887361072 ## core/src/main/java/org/apache/iceberg/rest/HTTPHeaders.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] Fix `Table.scan` to enable case sensitive argument [iceberg-python]

2024-12-16 Thread via GitHub
jiakai-li commented on code in PR #1423: URL: https://github.com/apache/iceberg-python/pull/1423#discussion_r1887376637 ## pyiceberg/table/__init__.py: ## @@ -268,12 +268,10 @@ def _apply(self, updates: Tuple[TableUpdate, ...], requirements: Tuple[TableRequ return se

Re: [I] Table scan doesn't respect casesensitive argument [iceberg-python]

2024-12-16 Thread via GitHub
jiakai-li closed issue #1421: Table scan doesn't respect casesensitive argument URL: https://github.com/apache/iceberg-python/issues/1421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Deserialize NestedField initial-default and write-default Attributes [iceberg-python]

2024-12-16 Thread via GitHub
paulcichonski commented on code in PR #1432: URL: https://github.com/apache/iceberg-python/pull/1432#discussion_r1887418287 ## tests/conftest.py: ## @@ -149,6 +149,35 @@ def table_schema_simple() -> Schema: ) +@pytest.fixture(scope="session") Review Comment: There w

Re: [PR] Flink: make `StatisticsOrRecord` to be correctly serialized and deser… [iceberg]

2024-12-16 Thread via GitHub
stevenzwu commented on code in PR #11557: URL: https://github.com/apache/iceberg/pull/11557#discussion_r1887477818 ## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/StatisticsOrRecordTypeInformation.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache

Re: [PR] Fix comment on `WRITE_OBJECT_STORE_PARTITIONED_PATHS` table property [iceberg]

2024-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11798: URL: https://github.com/apache/iceberg/pull/11798#discussion_r1887882188 ## core/src/main/java/org/apache/iceberg/TableProperties.java: ## @@ -244,7 +244,7 @@ private TableProperties() {} public static final String OBJECT_STORE

Re: [PR] Fix comment on `WRITE_OBJECT_STORE_PARTITIONED_PATHS` table property [iceberg]

2024-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11798: URL: https://github.com/apache/iceberg/pull/11798#discussion_r1887882188 ## core/src/main/java/org/apache/iceberg/TableProperties.java: ## @@ -244,7 +244,7 @@ private TableProperties() {} public static final String OBJECT_STORE

Re: [PR] chore: Generate Changelog Dependencies for 0.4.0 release [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo merged PR #812: URL: https://github.com/apache/iceberg-rust/pull/812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a

Re: [PR] Spec: Support geo type [iceberg]

2024-12-16 Thread via GitHub
jiayuasu commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1887892961 ## format/spec.md: ## @@ -584,8 +589,8 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | _optional_ |

Re: [PR] Spec: Support geo type [iceberg]

2024-12-16 Thread via GitHub
jiayuasu commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1887892961 ## format/spec.md: ## @@ -584,8 +589,8 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo | _optional_ | _optional_ | _optional_ |

Re: [I] [DISCUSS] Exceptions vs status codes [iceberg-cpp]

2024-12-16 Thread via GitHub
mapleFU commented on issue #14: URL: https://github.com/apache/iceberg-cpp/issues/14#issuecomment-2547519056 Personally I think if iceberg-cpp is just for parsing the metadata, all is ok for me. If it's also able to handle the dataset layer, I think exception might making maintaining the in

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1887922484 ## .github/.licenserc.yaml: ## @@ -0,0 +1,15 @@ +header: + license: +spdx-id: Apache-2.0 +copyright-owner: Apache Software Foundation + + paths: +- '**' +

Re: [PR] Doc: Add staus page for different implementations. [iceberg]

2024-12-16 Thread via GitHub
liurenjie1024 commented on code in PR #11772: URL: https://github.com/apache/iceberg/pull/11772#discussion_r1887930360 ## site/nav.yml: ## @@ -49,6 +49,7 @@ nav: - Multi-engine support: multi-engine-support.md - How to release: how-to-release.md - Terms: terms.md

Re: [PR] Add license checker [iceberg-cpp]

2024-12-16 Thread via GitHub
zhjwpku commented on code in PR #10: URL: https://github.com/apache/iceberg-cpp/pull/10#discussion_r1887940523 ## .github/workflows/license_check.yml: ## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] chore(docs): Update Readme - Lakekeeper repository moved [iceberg-rust]

2024-12-16 Thread via GitHub
liurenjie1024 merged PR #810: URL: https://github.com/apache/iceberg-rust/pull/810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [I] [DISCUSSION] Project Goal [iceberg-cpp]

2024-12-16 Thread via GitHub
GregoryKimball commented on issue #2: URL: https://github.com/apache/iceberg-cpp/issues/2#issuecomment-2547239172 Thank you for this discussion. > I would almost rather not depend on Arrow C++ if possible (what if I want to use the cuDF parquet reader, or OpenDAL for S3 access?)

Re: [I] DeleteOrphanFilesSparkAction.listDirRecursively - No FileSystem for scheme "s3" [iceberg]

2024-12-16 Thread via GitHub
github-actions[bot] commented on issue #10539: URL: https://github.com/apache/iceberg/issues/10539#issuecomment-2547212864 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] Flink-1.19: Fix the file offset mismatch when Flink reader first seek… [iceberg]

2024-12-16 Thread via GitHub
github-actions[bot] commented on PR #10567: URL: https://github.com/apache/iceberg/pull/10567#issuecomment-2547212923 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

<    1   2   3   >