Fokko commented on code in PR #1423:
URL: https://github.com/apache/iceberg-python/pull/1423#discussion_r1886374096
##########
pyiceberg/table/__init__.py:
##########
@@ -268,12 +268,10 @@ def _apply(self, updates: Tuple[TableUpdate, ...],
requirements: Tuple[TableRequ
return self
- def _scan(self, row_filter: Union[str, BooleanExpression] = ALWAYS_TRUE)
-> DataScan:
+ def _scan(self, row_filter: Union[str, BooleanExpression] = ALWAYS_TRUE,
case_sensitive: bool = True) -> DataScan:
Review Comment:
Hey @jiakai-li Sorry for my ambiguous message, let me clarify. The
`._scan()` returns a `DataScan` that accepts very few arguments because it
follows a builder pattern. With also adding the arguments, we invalidate that
pattern. Instead, below it should use
`._scan().with_case_sensitive(case_sensitive)`. However, it looks like this
ship has sailed already, and let's not block it since this is just a private
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
