rdblue commented on code in PR #11785:
URL: https://github.com/apache/iceberg/pull/11785#discussion_r1887251904
##########
data/src/test/java/org/apache/iceberg/data/parquet/TestGenericData.java:
##########
@@ -131,14 +136,143 @@ public void testTwoLevelList() throws IOException {
.reuseContainers()
.createReaderFunc(fileSchema ->
GenericParquetReaders.buildReader(schema, fileSchema))
.build()) {
- CloseableIterator it = reader.iterator();
- assertThat(it).hasNext();
- while (it.hasNext()) {
- GenericRecord actualRecord = (GenericRecord) it.next();
+ for (Record actualRecord : reader) {
assertThat(actualRecord.get(0,
ArrayList.class)).first().isEqualTo(expectedBinary);
assertThat(actualRecord.get(1,
ByteBuffer.class)).isEqualTo(expectedBinary);
- assertThat(it).isExhausted();
}
+
+ assertThat(Lists.newArrayList(reader).size()).isEqualTo(1);
}
}
+
+ @Test
+ public void testMissingRequiredWithoutDefault() {
+ Schema writeSchema =
+ new Schema(
+ required(1, "id", Types.LongType.get()),
Review Comment:
I'll drop the data field, but I think it's good to have an ID field so that
we get unique records and can compare the lists easily when debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
