Fokko commented on code in PR #804:
URL: https://github.com/apache/iceberg-rust/pull/804#discussion_r1886809213
##########
crates/iceberg/src/spec/table_metadata_builder.rs:
##########
@@ -740,6 +740,35 @@ impl TableMetadataBuilder {
.set_default_partition_spec(Self::LAST_ADDED)
}
+ /// Remove partition specs by their ids from the table metadata.
+ /// Does nothing if a spec id is not present.
+ ///
Review Comment:
Should we add a note here that it is not recommended to drop active
partitions (that are still being used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
