c-thiel commented on code in PR #804:
URL: https://github.com/apache/iceberg-rust/pull/804#discussion_r1886743717
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -446,6 +446,12 @@ pub enum TableUpdate {
/// Properties to remove
removals: Vec<String>,
},
+ /// Remove partition specs
+ #[serde(rename_all = "kebab-case")]
Review Comment:
This line is required as it renames the inner fields of the enum variant.
When its not there, the `test_remove_partition_specs_update` test fails as
`spec_ids` is wrongly serialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
