paulcichonski commented on code in PR #1432:
URL: https://github.com/apache/iceberg-python/pull/1432#discussion_r1887418287


##########
tests/conftest.py:
##########
@@ -149,6 +149,35 @@ def table_schema_simple() -> Schema:
     )
 
 
+@pytest.fixture(scope="session")

Review Comment:
   There were ~25 test failures when changing `table_schema_simple`, with some 
getting into the pyarrow schema conversions which were a bit more than a 
copy/paste change.
   
   I can probably figure it out, but might take a bit longer until I find time. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to