Fokko commented on code in PR #802:
URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1886929988
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -165,7 +175,7 @@ impl FileIOBuilder {
/// Fetch the scheme string.
///
/// The scheme_str will be empty if it's None.
- pub(crate) fn into_parts(self) -> (String, HashMap<String, String>) {
+ pub fn into_parts(self) -> (String, HashMap<String, String>) {
Review Comment:
What's the goal of the `scheme_str`? If we want to have a specific impl, we
could also pass that into the configuration itself. This is of course bound to
a language, [for example
`py-io-impl`](https://py.iceberg.apache.org/configuration/#fileio) and in Java
it is just `io-impl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
