amogh-jahagirdar commented on code in PR #11798: URL: https://github.com/apache/iceberg/pull/11798#discussion_r1887882188
########## core/src/main/java/org/apache/iceberg/TableProperties.java: ########## @@ -244,7 +244,7 @@ private TableProperties() {} public static final String OBJECT_STORE_ENABLED = "write.object-storage.enabled"; public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false; - // Excludes the partition values in the path when set to true and object store is enabled + // Excludes the partition values in the path when set to false and object store is enabled Review Comment: Nit: While this comment is correct, I feel like having the comment when the property is true reads a little bit more easy. ``` // Includes the partition values in the path when set to true and object store is enabled ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org