Fokko commented on code in PR #1422:
URL: https://github.com/apache/iceberg-python/pull/1422#discussion_r1886615423
##########
tests/test_transforms.py:
##########
@@ -988,608 +997,367 @@ def _test_projection(lhs:
Optional[UnboundPredicate[L]], rhs: Optional[UnboundPr
raise ValueError(f"Comparing unrelated: {lhs} <> {rhs}")
+def _assert_projection_strict(
+ pred: BooleanExpression,
+ transform: Transform[S, T],
+ expected_type: type[BooleanExpression],
+ expected_human_str: Optional[str] = None,
+) -> None:
+ result = transform.strict_project(name="name", pred=pred)
+
+ assert type(result) is expected_type or AlwaysFalse
Review Comment:
I agree, let me fix that in a follow up PR 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
