Roy Golan has posted comments on this change.
Change subject: core: Added affinity rules enforcement manager
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/41092/11/backend/manager/modules/bll/src/main/java/org/ovir
Roy Golan has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/42342/6/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py
Fi
Roy Golan has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 5:
Added a unittest. its WIP
--
To view, visit https://gerrit.ovirt.org/42342
To unsubscribe, visit ht
Roy Golan has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42342/3/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py
Fil
Roy Golan has posted comments on this change.
Change subject: webadmin: KSM enabled checkbox alway start unchecked
..
Patch Set 1:
findbugs not related. its on VdsDeploy.java
--
To view, visit https://gerrit.ovirt.org/42410
T
Roy Golan has uploaded a new change for review.
Change subject: core: Added qualifiers for CRUD actions for entities
..
core: Added qualifiers for CRUD actions for entities
Added an EntityAction qualifier. its useful for observi
Roy Golan has posted comments on this change.
Change subject: engine: Added readme to the policy units directory
..
Patch Set 1:
ping - how to progress?
--
To view, visit https://gerrit.ovirt.org/39338
To unsubscribe, visit h
Roy Golan has posted comments on this change.
Change subject: core: Added affinity rules enforcement manager
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/bll/src/test/java/org/ovirt
Roy Golan has posted comments on this change.
Change subject: core: Fix NPE in EditAffinityGroupCommandTest
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42398
To unsubscribe, visit https://gerrit.ovirt
Hello Doron Fediuck,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/42398
to review the following change.
Change subject: core: Fix NPE in EditAffinityGroupCommandTest
..
core: Fix NPE in EditAffi
Roy Golan has posted comments on this change.
Change subject: core: Start a service to solve affinity role breakage
..
Patch Set 6:
merge with the dependent patch or abandon.
--
To view, visit https://gerrit.ovirt.org/40990
T
Roy Golan has posted comments on this change.
Change subject: core: Added affinity rules enforcement manager
..
Patch Set 8:
(3 comments)
the unit test run?
https://gerrit.ovirt.org/#/c/41092/8/backend/manager/modules/bll/src
Roy Golan has posted comments on this change.
Change subject: core: Fix CDI in dal module to work with EAP/WildFly
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40151
To unsubscribe, visit https://g
Roy Golan has posted comments on this change.
Change subject: core: enable pinning to multiple hosts
..
Patch Set 12: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/41962/12/backend/manager/modules/bll/src/main/java/o
Roy Golan has posted comments on this change.
Change subject: core: enable pinning to multiple hosts
..
Patch Set 11:
(2 comments)
+1 BE except minor
https://gerrit.ovirt.org/#/c/41962/11/backend/manager/modules/bll/src/main/
Roy Golan has submitted this change and it was merged.
Change subject: core:Added affinity Group collision validation.
..
core:Added affinity Group collision validation.
CRUD Affinity Group Command's validateParameters() now ha
Roy Golan has posted comments on this change.
Change subject: core:Added affinity Group collision validation.
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41805
To unsubscribe, visit https://gerrit.
Roy Golan has posted comments on this change.
Change subject: core:Added affinity Group collision validation.
..
Patch Set 9: Code-Review+1
(4 comments)
last comments. all in all its straight forward
https://gerrit.ovirt.org/
Roy Golan has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42342/1/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py
Fil
Roy Golan has submitted this change and it was merged.
Change subject: core [DB]: Append database update script for KSM with NUMA
..
core [DB]: Append database update script for KSM with NUMA
Fix broken patch that mistekenly de
Roy Golan has posted comments on this change.
Change subject: core [DB]: Append database update script for KSM with NUMA
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42382
To unsubscribe, visit http
Roy Golan has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42342/1/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py
Fil
Roy Golan has posted comments on this change.
Change subject: engine: Add KSM policy to NUMA hosts
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/42373/4/backend/manager/modules/restapi/types/src/main/java/org/ovirt/
Roy Golan has posted comments on this change.
Change subject: Revert "engine: Add KSM policy to NUMA hosts"
..
Patch Set 1: Code-Review-2
fixed already. pls abandon
--
To view, visit https://gerrit.ovirt.org/42369
To unsubscr
Roy Golan has posted comments on this change.
Change subject: Revert "restapi: add field ksm_merge_across_node to cluster"
..
Patch Set 1: Code-Review-2
fixed already. you can abandon
--
To view, visit https://gerrit.ovirt.or
Roy Golan has posted comments on this change.
Change subject: engine: Add KSM policy to NUMA hosts
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42373
To unsubscribe, visit https://gerrit.ovirt.org/s
Roy Golan has submitted this change and it was merged.
Change subject: engine: Add KSM policy to NUMA hosts
..
engine: Add KSM policy to NUMA hosts
Fix skipped code, while rebase in patch https://gerrit.ovirt.org/#/c/39783/
fro
Roy Golan has posted comments on this change.
Change subject: scheduling: Add HostDevice Policy Unit
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42077
To unsubscribe, visit https://gerrit.ovirt.or
Roy Golan has posted comments on this change.
Change subject: core: enable pinning to multiple hosts
..
Patch Set 11:
(7 comments)
needs UI and REST
https://gerrit.ovirt.org/#/c/41962/11/backend/manager/modules/bll/src/main/j
Roy Golan has submitted this change and it was merged.
Change subject: engine: Add KSM policy to NUMA hosts
..
engine: Add KSM policy to NUMA hosts
Fix redundent import statement
Bug-Url: https://bugzilla.redhat.com/840114
Cha
Roy Golan has posted comments on this change.
Change subject: engine: Add KSM policy to NUMA hosts
..
Patch Set 1: Code-Review+2 Verified+1
fixes the import.
--
To view, visit https://gerrit.ovirt.org/42371
To unsubscribe, vi
Roy Golan has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42342/1/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py
Fil
Roy Golan has submitted this change and it was merged.
Change subject: restapi: add field ksm_merge_across_node to cluster
..
restapi: add field ksm_merge_across_node to cluster
Add element and type to api.xsd
Modified rsdl_met
Roy Golan has submitted this change and it was merged.
Change subject: engine: Add KSM policy to NUMA hosts
..
engine: Add KSM policy to NUMA hosts
1. Update MomPolicyVDSparameters and with new ksmMergeAcrossNodes field
2. Upda
Roy Golan has posted comments on this change.
Change subject: engine: Add KSM policy to NUMA hosts
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/39864
To unsubscribe, visit https://gerrit.ovirt.org/sett
Roy Golan has posted comments on this change.
Change subject: engine: Add KSM policy to NUMA hosts
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39864
To unsubscribe, visit https://gerrit.ovirt.org/s
Roy Golan has posted comments on this change.
Change subject: core:Added affinity Group collision validation.
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/41805/7/backend/manager/modules/bll/src/main/java/org/ovir
Roy Golan has posted comments on this change.
Change subject: core: Added affinity rules enforcement manager
..
Patch Set 7:
(11 comments)
https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/bll/src/main/java/org/ovir
Roy Golan has posted comments on this change.
Change subject: engien: Add KSM policy to NUMA hosts
..
Patch Set 8:
(5 comments)
https://gerrit.ovirt.org/#/c/39864/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/co
Roy Golan has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 1:
WIP
- missing devices(disks)
- emulated machine will be taken from the machine?
- cpu type as wel
Roy Golan has uploaded a new change for review.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Convert OVF to VDSM create parameters (vm.conf)
Change-Id: Ie7dd763dd701158e945ed2006520c6a073318d2c
Signed-off-b
Roy Golan has uploaded a new change for review.
Change subject: Add intellij files to .gitignore
..
Add intellij files to .gitignore
Change-Id: I76fab22d129db4bcac8e252a66614eec8f6ff6d9
Signed-off-by: Roy Golan
---
M .gitignore
Roy Golan has posted comments on this change.
Change subject: engien: Add KSM policy to NUMA hosts
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/39864/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/co
Roy Golan has posted comments on this change.
Change subject: engien: Add KSM policy to NUMA hosts
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/39864/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/co
Roy Golan has posted comments on this change.
Change subject: engien: Add KSM policy to NUMA hosts
..
Patch Set 6:
(5 comments)
https://gerrit.ovirt.org/#/c/39864/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/co
Roy Golan has submitted this change and it was merged.
Change subject: webadmin: Add KSM awaremess for NUMA optimization
..
webadmin: Add KSM awaremess for NUMA optimization
Add GUI to manage the KSM policy for NUMA at cluster
Roy Golan has posted comments on this change.
Change subject: engine: Add KSM awaremess for NUMA optimization
..
Patch Set 22: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/39777
To unsubscribe, visit htt
Roy Golan has submitted this change and it was merged.
Change subject: engine: Add KSM awaremess for NUMA optimization
..
engine: Add KSM awaremess for NUMA optimization
Add boolean field to cluster table reflecting KSM policy
Roy Golan has uploaded a new change for review.
Change subject: core: Allow importing hosted engine storage domain
..
core: Allow importing hosted engine storage domain
Allow importing the special storage domain of the hosted en
Roy Golan has uploaded a new change for review.
Change subject: core: Fix and relax some parsing of VM structures
..
core: Fix and relax some parsing of VM structures
- Create a null-safe parsing method for VM architecture
- Par
Roy Golan has uploaded a new change for review.
Change subject: core: Allow removing a running Hosted Engine VM from the setup
..
core: Allow removing a running Hosted Engine VM from the setup
to support auto-importing the he vm
Roy Golan has uploaded a new change for review.
Change subject: core: Invoke FullList command using the resource manager
..
core: Invoke FullList command using the resource manager
direct constructor usage is not recommended. th
Roy Golan has uploaded a new change for review.
Change subject: core: Import the hosted engine VM if its no manged
..
core: Import the hosted engine VM if its no manged
Let the monitoring import the HE VM if its not in the setup
Roy Golan has posted comments on this change.
Change subject: engine: Add KSM awaremess for NUMA optimization
..
Patch Set 21: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39777
To unsubscribe, visit https://gerrit
Roy Golan has posted comments on this change.
Change subject: packaging: setup: saving the configuration on the shared domain
..
Patch Set 16: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/42052/16/src/ovirt_hosted_e
Roy Golan has posted comments on this change.
Change subject: Engine: Scheduling-policy removal error message correction
..
Patch Set 6:
ping
--
To view, visit https://gerrit.ovirt.org/38574
To unsubscribe, visit https://gerr
Roy Golan has posted comments on this change.
Change subject: webadmin: Added range values to QoS error message.
..
Patch Set 11:
the parent fix is +2 . please verify and push ASAP
--
To view, visit https://gerrit.ovirt.org/3
Roy Golan has posted comments on this change.
Change subject: core: validator - include range as constraint message
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39395
To unsubscribe, visit https://g
Roy Golan has posted comments on this change.
Change subject: engine: Add KSM awaremess for NUMA optimization
..
Patch Set 16: Code-Review+1
Backend +1 - just spin the db script version, now needs UI
--
To view, visit https:/
Roy Golan has submitted this change and it was merged.
Change subject: Remove UpdatePartialVdsDynamicCalc stored procedure
..
Remove UpdatePartialVdsDynamicCalc stored procedure
This procedure is no longer needed and was remove
Roy Golan has posted comments on this change.
Change subject: core: enable pinning to multiple hosts
..
Patch Set 8:
(12 comments)
partial comments
https://gerrit.ovirt.org/#/c/41962/8/backend/manager/modules/bll/src/main/jav
Roy Golan has posted comments on this change.
Change subject: core: enable pinning to multiple hosts
..
Patch Set 8:
Martin we should probably make pin to hosts and host-devices mutually exclusive
and block using one of them i
Roy Golan has posted comments on this change.
Change subject: core: Gluster disk as network device
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41899/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engi
Roy Golan has submitted this change and it was merged.
Change subject: frontend: consider Everyone->diskProfileUser as basic user
permission
..
frontend: consider Everyone->diskProfileUser as basic user permission
Similar to v
Roy Golan has posted comments on this change.
Change subject: frontend: consider Everyone->diskProfileUser as basic user
permission
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41834/3/frontend/webadmin/modules/ui
Roy Golan has posted comments on this change.
Change subject: frontend: consider Everyone->diskProfileUser as basic user
permission
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/41834
To unsubscribe, v
Roy Golan has posted comments on this change.
Change subject: frontend: consider Everyone->diskProfileUser as basic user
permission
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41834/1/frontend/webadmin/modules/ui
Roy Golan has uploaded a new change for review.
Change subject: frontend: consider Everyone->diskProfileUser as basic user
permission
..
frontend: consider Everyone->diskProfileUser as basic user permission
Similar to vnicProfi
Roy Golan has submitted this change and it was merged.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
PendingResourceManager for tracking resources in WaitForLaunch
This patch adds a new sched
Roy Golan has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 20: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40136
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 19: Code-Review+2
minor api visibility thing - let make the decreasePending in vmHandler
Roy Golan has posted comments on this change.
Change subject: userportal: Fixed New Template dialog size
..
Patch Set 1:
ping
--
To view, visit https://gerrit.ovirt.org/41100
To unsubscribe, visit https://gerrit.ovirt.org/set
Roy Golan has posted comments on this change.
Change subject: core: update scheduling stats only if GetStats succeeded
..
Patch Set 2:
(1 comment)
looks right anyway. thanks!
https://gerrit.ovirt.org/#/c/41569/2/backend/manag
Roy Golan has posted comments on this change.
Change subject: core: update scheduling stats only if GetStats succeeded
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41569
To unsubscribe, visit https:
Roy Golan has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 34:
(1 comment)
https://gerrit.ovirt.org/#/c/35887/34/backend/manager/modules/services/src/main/java
Roy Golan has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 34:
(1 comment)
https://gerrit.ovirt.org/#/c/35887/34/backend/manager/modules/services/src/main/java
Roy Golan has submitted this change and it was merged.
Change subject: core: Fix FB issue in VdsCpuUsageComparator
..
core: Fix FB issue in VdsCpuUsageComparator
This patch fixes the following FindBugs warning on this class:
"
Roy Golan has posted comments on this change.
Change subject: core: Fix FB issue in VdsCpuUsageComparator
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41265
To unsubscribe, visit https://gerrit.ovir
Roy Golan has submitted this change and it was merged.
Change subject: core: Remove the usage of static getInstance in
SchedulerUtilQuartzImpl
..
core: Remove the usage of static getInstance in SchedulerUtilQuartzImpl
Change-I
Roy Golan has posted comments on this change.
Change subject: core: Remove the usage of static getInstance in
SchedulerUtilQuartzImpl
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41063
To unsubscri
Roy Golan has submitted this change and it was merged.
Change subject: core: Inject QuotaManager and make it a BackendService
..
core: Inject QuotaManager and make it a BackendService
Change-Id: I272f22c4fdbcb96d27e9d5c84a679af
Roy Golan has posted comments on this change.
Change subject: core: Inject QuotaManager and make it a BackendService
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41041
To unsubscribe, visit https:/
Roy Golan has submitted this change and it was merged.
Change subject: core: Inject AutoStartVmsRunner and make it a BackendService
..
core: Inject AutoStartVmsRunner and make it a BackendService
Change-Id: I5fdf736e8ae33b8b55a
Roy Golan has posted comments on this change.
Change subject: core: Inject AutoStartVmsRunner and make it a BackendService
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41040
To unsubscribe, visit h
Roy Golan has submitted this change and it was merged.
Change subject: core: Make VmpoolMonitor a BackendService and a CDI bean
..
core: Make VmpoolMonitor a BackendService and a CDI bean
Change-Id: Icaadcc92ae352e8a775dee321b7
Roy Golan has posted comments on this change.
Change subject: core: Make VmpoolMonitor a BackendService and a CDI bean
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41039
To unsubscribe, visit https
Roy Golan has submitted this change and it was merged.
Change subject: core: Make DwhHeartBeat a BackendService and a CDI bean
..
core: Make DwhHeartBeat a BackendService and a CDI bean
Change-Id: I53589a48f302d6b3711afa144b666
Roy Golan has submitted this change and it was merged.
Change subject: core: Make Singletons also BackendService and load them
..
core: Make Singletons also BackendService and load them
- Use CDI programatic API to fetch instan
Roy Golan has submitted this change and it was merged.
Change subject: core: Inject CacheManager instead of jndi lookup
..
core: Inject CacheManager instead of jndi lookup
- Make CacheManager a @Singleton bean
- don't do a jndi
Roy Golan has submitted this change and it was merged.
Change subject: core: Inject Task schedulers instead of JNDI lookups
..
core: Inject Task schedulers instead of JNDI lookups
continue the JNDI and EJB cleanup and move Sing
Roy Golan has posted comments on this change.
Change subject: core: Make VmpoolMonitor a BackendService and a CDI bean
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/41039
To unsubscribe, visit https://
Roy Golan has posted comments on this change.
Change subject: core: Inject QuotaManager and make it a BackendService
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/41041
To unsubscribe, visit https://ge
Roy Golan has posted comments on this change.
Change subject: core: Make Singletons also BackendService and load them
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/41037
To unsubscribe, visit https://g
Roy Golan has posted comments on this change.
Change subject: core: Inject AutoStartVmsRunner and make it a BackendService
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/41040
To unsubscribe, visit http
Roy Golan has posted comments on this change.
Change subject: core: Remove the usage of static getInstance in
SchedulerUtilQuartzImpl
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/41063
To unsubscribe,
Roy Golan has posted comments on this change.
Change subject: core: Inject Task schedulers instead of JNDI lookups
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/41035
To unsubscribe, visit https://gerr
Roy Golan has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 33:
(1 comment)
https://gerrit.ovirt.org/#/c/35887/33/backend/manager/modules/services/src/main/java
Roy Golan has posted comments on this change.
Change subject: core: Move Job, Step to JPA
..
Patch Set 53: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/34553
To unsubscribe, visit https://gerrit.ovirt.org/settings
Roy Golan has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 33:
(3 comments)
https://gerrit.ovirt.org/#/c/35887/33/backend/manager/modules/services/src/main/jav
Roy Golan has posted comments on this change.
Change subject: core, engine: servlet to support the console proxy
..
Patch Set 33:
(1 comment)
https://gerrit.ovirt.org/#/c/35887/33/backend/manager/modules/services/src/main/java
1 - 100 of 3735 matches
Mail list logo
