Roy Golan has posted comments on this change. Change subject: core: Added affinity rules enforcement manager ......................................................................
Patch Set 7: (4 comments) https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java: Line 42: import static org.mockito.Mockito.doReturn; Line 43: import static org.mockito.Mockito.mock; Line 44: import static org.mockito.Mockito.when; Line 45: Line 46: @RunWith(MockitoJUnitRunner.class) tomer if this is not converging just add @Ignore annotation on the class and will not run. and we'll fix it later Line 47: public class AffinityRulesEnforcementManagerTest { Line 48: AffinityRulesEnforcementManager arem; Line 49: Line 50: @Rule https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 1234: AFFINITY_RULES_ENFORCEMENT_MANAGER_INTERVAL_REACHED we don't really need it. that's for regular log https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 472: AffinityRulesEnforcementManagerStart you probably mixed that with an Auditlog type. please remove. https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 1048: AFFINITY_RULES_ENFORCEMENT_MANAGER_INTERVAL_REACHED again not needed -- To view, visit https://gerrit.ovirt.org/41092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674666a4e84ca0f4bb3ed7eb96654f2362020d4d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
