Roy Golan has posted comments on this change. Change subject: Convert OVF to VDSM create parameters (vm.conf) ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/42342/3/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py File src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py: Line 26: Line 27: def diskFromElemts(device, diskElement, diskIndex): Line 28: disk = {} Line 29: if diskIndex == 2: Line 30: # 2 is save for CDROM > just a nit.. "reserved" would be better imho Done Line 31: diskIndex = 3 Line 32: disk['index'] = diskIndex Line 33: disk['type'] = device.find('Type').text Line 34: disk['device'] = device.find('Device').text -- To view, visit https://gerrit.ovirt.org/42342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7dd763dd701158e945ed2006520c6a073318d2c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
