Roy Golan has posted comments on this change. Change subject: frontend: consider Everyone->diskProfileUser as basic user permission ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41834/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java: Line 211: // ALL Everyone/DiskProfileUser permissions Line 212: if (isPermissionOf(everyone, userTemplateBasedVM, permission) Line 213: || isPermissionOf(everyone, quotaConsumer, permission) Line 214: || isPermissionOf(everyone, vnicProfileUser, permission) Line 215: || isPermissionOf(everyone, diskProfileUser, permission) > One minor suggestion, which if not implemented is not a big deal. But you c I'm thinking about creating a backend query and delete the hell out of those 300 lines of code. after looking at those stepsm it doesn't look right to just pile more and more exclusions for regular users. it should be other way round Line 216: || isPermissionOf(everyone, userProfileEditor, permission)) { Line 217: continue; Line 218: } Line 219: if (!roleIdList.contains(permission.getRoleId())) -- To view, visit https://gerrit.ovirt.org/41834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81bf88b7d4d0e16142dfad83b2e0d03039243a18 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
