Roy Golan has posted comments on this change. Change subject: packaging: setup: saving the configuration on the shared domain ......................................................................
Patch Set 16: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/42052/16/src/ovirt_hosted_engine_setup/heconflib.py File src/ovirt_hosted_engine_setup/heconflib.py: Line 123: contain content? Line 216: 'bs=4k', Line 217: ] Line 218: if logger: Line 219: logger.debug("executing: '{cmd}'".format(cmd=' '.join(cmd_list))) Line 220: pipe = subprocess.Popen( I'm not a python api expert, shouldn't the pipe be closed at the end? Line 221: cmd_list, Line 222: stdin=subprocess.PIPE, Line 223: stdout=subprocess.PIPE, Line 224: stderr=subprocess.PIPE, -- To view, visit https://gerrit.ovirt.org/42052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1096aa6eabf97ac9cf9b032d0ac57fd8f63c2924 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
