Roy Golan has posted comments on this change. Change subject: core: enable pinning to multiple hosts ......................................................................
Patch Set 12: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/41962/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java: Line 72: supportedNUMAMigration I said its weird because it is reads like that x = !Config.get(x) which is confusing. no? https://gerrit.ovirt.org/#/c/41962/12/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java: Line 70: .addValue("kernel_url", entity.getKernelUrl()) Line 71: .addValue("kernel_params", entity.getKernelParams()) Line 72: .addValue("quota_id", entity.getQuotaId()) Line 73: .addValue("migration_support", entity.getMigrationSupport().getValue()) Line 74: .addValue("dedicated_vm_for_vds", presistDedicatedVmForVdsList) TODO inline it, same as line 79 Line 75: .addValue("min_allocated_mem", entity.getMinAllocatedMem()) Line 76: .addValue("is_run_and_pause", entity.isRunAndPause()) Line 77: .addValue("created_by_user_id", entity.getCreatedByUserId()) Line 78: .addValue("migration_downtime", entity.getMigrationDowntime()) -- To view, visit https://gerrit.ovirt.org/41962 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I710bd8d3505552a2a8d6060194d94c68c05445db Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
