Roy Golan has posted comments on this change. Change subject: Convert OVF to VDSM create parameters (vm.conf) ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/42342/6/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py File src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py: Line 104: def convert(ovf): Line 105: """ Line 106: Convert an OVF string to a vmConf dictionary Line 107: :param ovf: the OVF string Line 108: :type String need to improve this "type:" doc. its not the right form Line 109: :return: dict to be used to create a new VM using vdsCli - See vdsCli#create Line 110: """ Line 111: tree = ovfenvelope.etree_.fromstring(ovf) Line 112: Line 152: ).join( Line 153: [('%s=%s\n' % ('devices', Line 154: str(item).replace('\'', '').replace(' ', ''))) Line 155: for item in devices] Line 156: ) I'll probably concat instead of 2 joins because python compiles the code different than what I expect. the out put is devices={the first device} vmId= ... the rest of the attr devices={the second device} while I expected it to join both devices at the end. Line 157: Line 158: Line 159: if __name__ == '__main__': Line 160: print(confFromOvf(sys.argv[1])) -- To view, visit https://gerrit.ovirt.org/42342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7dd763dd701158e945ed2006520c6a073318d2c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
