Roy Golan has posted comments on this change.

Change subject: Convert OVF to VDSM create parameters (vm.conf)
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42342/1/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py
File src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py:

Line 25: def ovf2vmConf(ovfPath):
Line 26:     tmpdir = tempfile.mkdtemp()
Line 27:     tree = ovfenvelope.etree_.parse(
Line 28:         os.path.join(
Line 29:             tmpdir,
> tmpdir is a fresh temp directory, the OVF file is not there
will remove. that was for testing.
Line 30:             ovfPath,
Line 31:         )
Line 32:     )
Line 33:     vmConf = {}


-- 
To view, visit https://gerrit.ovirt.org/42342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7dd763dd701158e945ed2006520c6a073318d2c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to