Roy Golan has posted comments on this change. Change subject: engien: Add KSM policy to NUMA hosts ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/39864/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java: Line 134: Line 135: if (getParameters().isForceResetEmulatedMachine()) { Line 136: getParameters().getVdsGroup().setDetectEmulatedMachine(true); Line 137: } Line 138: // if ksm-enabled updated or ksm-merge-across-nodes updated > endSuccesfully() is called from runInTransaction() method. so this section should be put into a method of its own and be called from at the end of successful execution. Line 139: if ((getVdsGroup().isKsmMergeAcrossNumaNodes() != getPrevVdsGroup().isKsmMergeAcrossNumaNodes()) || Line 140: (getVdsGroup().isEnableKsm() != getPrevVdsGroup().isEnableKsm())) { Line 141: MomPolicyUpdateParams eventParams = new MomPolicyUpdateParams(getVdsGroup(), allForVdsGroup); Line 142: https://gerrit.ovirt.org/#/c/39864/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java: Line 52: * Get the cluster object as it is in database before update Line 53: * Line 54: * @return Current cluster object before database update, or null if not existing Line 55: */ Line 56: public VDSGroup getPrevVdsGroup() { > public VDSGroup getVdsGroup() { not your fault, there's a convention violation here. the convention is that all get{Entity} methods on commands return the db entities while getParameters().get{Entity} return the request instance I don't mind you clearing this in subsequent patch, as this should be rectified. Line 57: return super.getVdsGroup(); Line 58: } Line 59: Line 60: @Override -- To view, visit https://gerrit.ovirt.org/39864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9efa046547fb3732f0fb059092e5f444d72d589c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
