Roy Golan has posted comments on this change. Change subject: core: Added affinity rules enforcement manager ......................................................................
Patch Set 7: (11 comments) https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 48: @Inject Line 49: private Instance<BackendService> services; Line 50: Line 51: @Inject Line 52: private AffinityRulesEnforcementManager aremManager; I want it as a backendService. and load it at InitBackendServicesOnStartupBean Line 53: Line 54: /** Line 55: * This method is called upon the bean creation as part Line 56: * of the management Service bean life cycle. https://gerrit.ovirt.org/#/c/41092/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java: Line 40: Line 41: @Singleton Line 42: public class AffinityRulesEnforcementManager { Line 43: //Definitions Line 44: //Fields redundant comment? Line 45: Map<VDSGroup, AffinityRulesEnforcementPerCluster> perClusterMap; Line 46: Iterator<AffinityRulesEnforcementPerCluster> AreClusterIterator = Collections.emptyIterator(); Line 47: Integer currentInterval; Line 48: Line 41: @Singleton Line 42: public class AffinityRulesEnforcementManager { Line 43: //Definitions Line 44: //Fields Line 45: Map<VDSGroup, AffinityRulesEnforcementPerCluster> perClusterMap; private members, please Line 46: Iterator<AffinityRulesEnforcementPerCluster> AreClusterIterator = Collections.emptyIterator(); Line 47: Integer currentInterval; Line 48: Line 49: private String jobId; Line 42: public class AffinityRulesEnforcementManager { Line 43: //Definitions Line 44: //Fields Line 45: Map<VDSGroup, AffinityRulesEnforcementPerCluster> perClusterMap; Line 46: Iterator<AffinityRulesEnforcementPerCluster> AreClusterIterator = Collections.emptyIterator(); same Line 47: Integer currentInterval; Line 48: Line 49: private String jobId; Line 50: Line 43: //Definitions Line 44: //Fields Line 45: Map<VDSGroup, AffinityRulesEnforcementPerCluster> perClusterMap; Line 46: Iterator<AffinityRulesEnforcementPerCluster> AreClusterIterator = Collections.emptyIterator(); Line 47: Integer currentInterval; same you can just use int. it will auto-unbox from the config value Line 48: Line 49: private String jobId; Line 50: Line 51: @Inject Line 53: @Inject Line 54: protected VdsDAO vdsDao; Line 55: @Inject Line 56: protected VdsGroupDAO vdsGroupDao; Line 57: redundant line Line 58: @Inject Line 59: Instance<AffinityRulesEnforcementPerCluster> perClusterProvider; Line 60: Line 61: @PostConstruct Line 55: @Inject Line 56: protected VdsGroupDAO vdsGroupDao; Line 57: Line 58: @Inject Line 59: Instance<AffinityRulesEnforcementPerCluster> perClusterProvider; private Line 60: Line 61: @PostConstruct Line 62: protected void wakeup() { Line 63: long regularInterval = getRegularInterval(); Line 65: new Long(re use longValue() Line 107: getLongInterval name is a bit misleading. what do you refer as Long interval? Line 111: //Called each interval replace with proper Java doc Line 114: AuditLogableBase logable = new AuditLogableBase(); : auditLogDirector.log(logable, AuditLogType.AFFINITY_RULES_ENFORCEMENT_MANAGER_INTERVAL_REACHED); you meant regular log maybe? this is the event log which goes in the event tab -- To view, visit https://gerrit.ovirt.org/41092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674666a4e84ca0f4bb3ed7eb96654f2362020d4d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
