Roy Golan has posted comments on this change. Change subject: engine: Add KSM policy to NUMA hosts ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/42373/4/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java: Line 170: KSM ksm = model.getKsm(); Line 171: if (ksm == null) { Line 172: ksm = new KSM(); Line 173: model.setKsm(ksm); Line 174: } > Remember to fix formatting before merging: 4 spaces per level. sorry, I merged as soon as you you gave +1 cause the build was broken. Dudi will send a new patch for that. Line 175: ksm.setEnabled(entity.isEnableKsm()); Line 176: ksm.setMergeAcrossNodes(entity.isKsmMergeAcrossNumaNodes()); Line 177: if (StringUtils.isNotBlank(entity.getSpiceProxy())) { Line 178: Display display = new Display(); -- To view, visit https://gerrit.ovirt.org/42373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23aee2305902c0dcfc4dbf89221e4c60a4acf602 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
