Martin Sivák has posted comments on this change.
Change subject: Convert OVF to VDSM create parameters (vm.conf)
..
Patch Set 3: Code-Review+1
(1 comment)
I would like to see a sanity unit test as well. But it looks good.
htt
Martin Sivák has posted comments on this change.
Change subject: core: Added affinity rules enforcement manager
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41092
To unsubscribe, visit https://gerr
Martin Sivák has posted comments on this change.
Change subject: core: Added affinity rules enforcement manager
..
Patch Set 8: Code-Review+1
I am ok with this after the changes.
--
To view, visit https://gerrit.ovirt.org/410
Martin Sivák has posted comments on this change.
Change subject: core: Allow removing a running Hosted Engine VM from the setup
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/42296/2/backend/manager/modules/bll/src/m
Martin Sivák has posted comments on this change.
Change subject: core: Fix and relax some parsing of VM structures
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42297
To unsubscribe, visit https://ge
Martin Sivák has submitted this change and it was merged.
Change subject: removing service condition on vm.conf
..
removing service condition on vm.conf
The agent will dinamically load vm.conf from the shared
storage domain so
Martin Sivák has posted comments on this change.
Change subject: removing service condition on vm.conf
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42389
To unsubscribe, visit https://gerrit.ovirt.o
Martin Sivák has submitted this change and it was merged.
Change subject: loading broker.conf and vm.conf from the shared storage
..
loading broker.conf and vm.conf from the shared storage
broker.conf and vm.conf are now on th
Martin Sivák has posted comments on this change.
Change subject: loading broker.conf and vm.conf from the shared storage
..
Patch Set 20: Code-Review+2
Looks good to me after the great explanation.
--
To view, visit https://g
Martin Sivák has posted comments on this change.
Change subject: core:Added affinity Group collision validation.
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41805
To unsubscribe, visit https://gerr
Martin Sivák has posted comments on this change.
Change subject: scheduling: Add HostDevice Policy Unit
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42077
To unsubscribe, visit https://gerrit.ovirt
Martin Sivák has posted comments on this change.
Change subject: core: Added affinity rules enforcement manager
..
Patch Set 7: Code-Review-1
(4 comments)
The documentation needs to be improved a lot. Some of the comments desc
Martin Sivák has posted comments on this change.
Change subject: loading broker.conf and vm.conf from the shared storage
..
Patch Set 20: Code-Review-1
-1 just because I need one answer, otherwise it looks good.
I wonder what
Martin Sivák has uploaded a new change for review.
Change subject: Update mom version to 0.4.5
..
Update mom version to 0.4.5
Change-Id: Idbe9a0cf54edb360dffa42269044dbad359375cc
Signed-off-by: Martin Sivak
---
M configure.ac
1
Martin Sivák has posted comments on this change.
Change subject: Allow using unix socket for the RPC port
..
Patch Set 4: Verified+1
Verified using VDSM test suite.
--
To view, visit https://gerrit.ovirt.org/42228
To unsubscr
Martin Sivák has posted comments on this change.
Change subject: Allow using unix socket for the RPC port
..
Patch Set 3: Verified+1
Just a version fix. No change to code.
--
To view, visit https://gerrit.ovirt.org/42228
To u
Martin Sivák has posted comments on this change.
Change subject: Allow using unix socket for the RPC port
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/42228/2/configure.ac
File configure.ac:
Line 17
Line 18
Line
Martin Sivák has posted comments on this change.
Change subject: Allow using unix socket for the RPC port
..
Patch Set 2: Verified+1
Reverified using VDSM tests. This change only fixes the most blatant PEP
violations in the or
Martin Sivák has uploaded a new change for review.
Change subject: Allow using unix socket for the RPC port
..
Allow using unix socket for the RPC port
This adds a code that is able to start an XML-RPC server listening
on unix s
Martin Sivák has posted comments on this change.
Change subject: Handle Sanlock issues properly when force cleaning
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42202
To unsubscribe, visit https://g
Martin Sivák has submitted this change and it was merged.
Change subject: Handle Sanlock issues properly when force cleaning
..
Handle Sanlock issues properly when force cleaning
Bug-Url: https://bugzilla.redhat.com/show_bug.cg
Martin Sivák has posted comments on this change.
Change subject: scheduling: Add HostDevice Policy Unit
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42077
To unsubscribe, visit https://gerrit.ovirt.
Martin Sivák has posted comments on this change.
Change subject: loading broker.conf from the shared storage
..
Patch Set 5:
Please update the spec file so the package owns the statedir and the existing
configuration from /etc
Martin Sivák has posted comments on this change.
Change subject: packaging: setup: saving the configuration on the shared domain
..
Patch Set 17: Code-Review+1
It looks OK to me, we might do some refactoring of the parts shared
Martin Sivák has posted comments on this change.
Change subject: Add two new recover commands to the hosted-engine tool
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/42093
To unsubscribe, visit https://
Martin Sivák has posted comments on this change.
Change subject: Add two new recover commands to the hosted-engine tool
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/42093
To unsubscribe, visit https://
Martin Sivák has uploaded a new change for review.
Change subject: Handle Sanlock issues properly when force cleaning
..
Handle Sanlock issues properly when force cleaning
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=111
Martin Sivák has posted comments on this change.
Change subject: Handle Sanlock issues properly when force cleaning
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42202
To unsubscribe, visit https://gerr
Martin Sivák has posted comments on this change.
Change subject: core:Added affinity Group collision validation.
..
Patch Set 6: Code-Review+1
I am still not 100% satisfied with the algorithm description, I would prefer a
bett
Martin Sivák has uploaded a new change for review.
Change subject: Add two new recover commands to the hosted-engine tool
..
Add two new recover commands to the hosted-engine tool
This adds new interface to two hosted engine ope
Martin Sivák has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 8: Verified+1
Minor fix, nothing affecting the functionality.
--
To view,
Martin Sivák has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/41570/7/mom/HypervisorInterfa
Martin Sivák has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/41570
To unsubscr
Martin Sivák has posted comments on this change.
Change subject: core:Added affinity Group collision validation.
..
Patch Set 5: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/41805/5/backend/manager/modules/bll/src/m
Martin Sivák has posted comments on this change.
Change subject: Remove UpdatePartialVdsDynamicCalc stored procedure
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41821
To unsubscribe, visit https://ger
Martin Sivák has posted comments on this change.
Change subject: Include line number in parsing and runtime policy error messages
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42043
To unsubscribe, visi
Martin Sivák has posted comments on this change.
Change subject: Define argument types for builtins and operators
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42042
To unsubscribe, visit https://gerrit
Martin Sivák has posted comments on this change.
Change subject: Improve 'and' and 'or' operators to accept unlimited number of
arguments
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42041
To unsubscr
Martin Sivák has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/41570/6/mom/HypervisorInterfa
Martin Sivák has uploaded a new change for review.
Change subject: Include line number in parsing and runtime policy error messages
..
Include line number in parsing and runtime policy error messages
The current code only return
Martin Sivák has uploaded a new change for review.
Change subject: Improve 'and' and 'or' operators to accept unlimited number of
arguments
..
Improve 'and' and 'or' operators to accept unlimited number of arguments
It was not
Martin Sivák has uploaded a new change for review.
Change subject: Define argument types for builtins and operators
..
Define argument types for builtins and operators
Signed-off-by: Martin Sivak
Change-Id: I2bd1bb96099e6c65b2e
Martin Sivák has posted comments on this change.
Change subject: Added affinity Group collision test to canDoAction
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/41805/3/backend/manager/modules/bll/src/main/java/or
Martin Sivák has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 6: Verified+1
I have the code running against patched VDSM (cpu tune and ks
Martin Sivák has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/41570/5/mom/HypervisorInterfa
Martin Sivák has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/41570/4/mom/HypervisorInterfac
Martin Sivák has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41570/3/mom/HypervisorInterfac
Martin Sivák has posted comments on this change.
Change subject: New hypervisor interface for remote VDSM over XML-RPC with
stats caching
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41570/2/mom/HypervisorInterfac
Martin Sivák has uploaded a new change for review.
Change subject: Remove UpdatePartialVdsDynamicCalc stored procedure
..
Remove UpdatePartialVdsDynamicCalc stored procedure
This procedure is no longer needed and was removed fro
Martin Sivák has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 20: Verified+1
--
To view, visit https://gerrit.ovirt.org/40136
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: monitor: implement NUMA aware KSM policy
..
Patch Set 8:
I know this is merged, but there is a typo in the collector:
ksm_share_across_nodes != merge_across_nod
Martin Sivák has abandoned this change.
Change subject: Add scheduling filter that checks NUMA compatibility
..
Abandoned
Not needed atm...
--
To view, visit https://gerrit.ovirt.org/34699
To unsubscribe, visit https://gerrit
Martin Sivák has posted comments on this change.
Change subject: Release ovirt-hosted-engine-ha-1.2.6-2
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41281
To unsubscribe, visit https://gerrit.ovirt.
Martin Sivák has submitted this change and it was merged.
Change subject: Release ovirt-hosted-engine-ha-1.2.6-2
..
Release ovirt-hosted-engine-ha-1.2.6-2
Change-Id: Ie2ac4948922b223d09fd57ba039647aa6459e213
Signed-off-by: Mart
Martin Sivák has uploaded a new change for review.
Change subject: Release ovirt-hosted-engine-ha-1.2.6-2
..
Release ovirt-hosted-engine-ha-1.2.6-2
Change-Id: Ie2ac4948922b223d09fd57ba039647aa6459e213
Signed-off-by: Martin Sivak
Martin Sivák has abandoned this change.
Change subject: Release ovirt-hosted-engine-ha-1.2.6-2
..
Abandoned
Bad branch..
--
To view, visit https://gerrit.ovirt.org/41280
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Sivák has uploaded a new change for review.
Change subject: Release ovirt-hosted-engine-ha-1.2.6-2
..
Release ovirt-hosted-engine-ha-1.2.6-2
Change-Id: Ie2ac4948922b223d09fd57ba039647aa6459e213
Signed-off-by: Martin Sivak
Martin Sivák has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 17:
(2 comments)
https://gerrit.ovirt.org/#/c/40136/17/backend/manager/modules/bll/sr
Martin Sivák has posted comments on this change.
Change subject: webadmin: Added range values to QoS error message.
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/35318
To unsubscribe, visit https://
Martin Sivák has posted comments on this change.
Change subject: respect the timeout in EngineUpBadHealth state (better fix)
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40820
To unsubscr
Martin Sivák has submitted this change and it was merged.
Change subject: respect the timeout in EngineUpBadHealth state (better fix)
..
respect the timeout in EngineUpBadHealth state (better fix)
Change-Id: Id86274fabe5f66ee42
Martin Sivák has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 19: Verified+1
No logic change, just type refactoring and the code still compiles and
Martin Sivák has posted comments on this change.
Change subject: sla: Update balancers and add memory based load balancing
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/38189
To unsubscribe, visit http
Martin Sivák has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 17:
(20 comments)
https://gerrit.ovirt.org/#/c/40136/17/backend/manager/modules/bll/s
Martin Sivák has posted comments on this change.
Change subject: build: ovirt-hosted-engine-ha-1.2.6
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40865
To unsubscribe, visit https://gerrit.ovirt.org
Martin Sivák has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-ha-1.2.6
..
build: ovirt-hosted-engine-ha-1.2.6
Change-Id: I9168c188b4b72b40bfde783a437968f80dcdcc38
Signed-off-by: Sandro Bon
Hello Jiří Moskovčák,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40820
to review the following change.
Change subject: respect the timeout in EngineUpBadHealth state (better fix)
..
respect th
Martin Sivák has posted comments on this change.
Change subject: webadmin: Fixed capitalization on "New Cluster".
..
Patch Set 2: Verified+1
Verified on master as this is a trivial change.
--
To view, visit https://gerrit.ovi
Martin Sivák has posted comments on this change.
Change subject: webadmin: Fixed text wrapping in "New Cluster".
..
Patch Set 2: Verified+1
Verified on master as this is a trivial change.
--
To view, visit https://gerrit.ovir
Martin Sivák has posted comments on this change.
Change subject: WIP:VDSM interface using JSON-RPC
..
Patch Set 7:
(1 comment)
I like this, the only issue I have is with the VDSM code reuse. Reuse is a good
thing, but MOM sho
Martin Sivák has submitted this change and it was merged.
Change subject: be more verbose when starting the HE VM fails
..
be more verbose when starting the HE VM fails
Change-Id: Ieb4842048aa690925284d62685156f56485dd41e
Bug-U
Martin Sivák has posted comments on this change.
Change subject: be more verbose when starting the HE VM fails
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40777
To unsubscribe, visit htt
Hello Jiří Moskovčák,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40777
to review the following change.
Change subject: be more verbose when starting the HE VM fails
..
be more verbose when sta
Martin Sivák has posted comments on this change.
Change subject: core: SchedulingManager as CDI Singleton
..
Patch Set 1: Code-Review+1
I would prefer if my pending and memory scheduling patches (incl. Roy's) were
merged first
Martin Sivák has posted comments on this change.
Change subject: hosted-engine: hosted-engine client, with storage connection
timeout
..
Patch Set 6: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/40392/6/ovirt_hoste
Martin Sivák has posted comments on this change.
Change subject: webadmin: Added range values to QoS error message.
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/35318
To unsubscribe, visit https://g
Martin Sivák has posted comments on this change.
Change subject: print more user friendly error when VM is powered down while
running collectors
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/35883
T
Martin Sivák has posted comments on this change.
Change subject: don't print stack trace when the ha broker is unreachable
..
Patch Set 1: Verified+1
This has been part of master for some time.
--
To view, visit https://gerri
Martin Sivák has uploaded a new change for review.
Change subject: don't print stack trace when the ha broker is unreachable
..
don't print stack trace when the ha broker is unreachable
Change-Id: I02cfcd2a59ede40efaa0747a7dd3b9
Martin Sivák has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 17:
I also checked whether the affinity update works by mass starting three VMs
from
Martin Sivák has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 17: Verified+1
I saw updates to maximum memory available for scheduling during the bal
Martin Sivák has posted comments on this change.
Change subject: sla: Add support for basic PolicyUnit testing
..
Patch Set 16: Verified+1
I was able to compile the engine with the tests passing.
--
To view, visit https://ger
Martin Sivák has posted comments on this change.
Change subject: sla: Update balancers and add memory based load balancing
..
Patch Set 11: Verified+1
I was able to upgrade the engine (db check), set the memory properties and
Martin Sivák has posted comments on this change.
Change subject: core: commited counted was missing vms
..
Patch Set 6: Verified+1
Works as a charm on my setup.
--
To view, visit https://gerrit.ovirt.org/40611
To unsubscribe,
Martin Sivák has posted comments on this change.
Change subject: core: commited counted was missing vms
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40611
To unsubscribe, visit https://gerrit.ovirt.
Martin Sivák has posted comments on this change.
Change subject: core: commited counted was missing vms
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40611
To unsubscribe, visit https://gerrit.ovirt.
Martin Sivák has posted comments on this change.
Change subject: sla: Update balancers and add memory based load balancing
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/38189/9/backend/manager/modules/bll/src/main/j
Martin Sivák has posted comments on this change.
Change subject: hosted-engine: hosted-engine client, with storage connection
timeout
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40392/1/ovirt_hosted
Martin Sivák has posted comments on this change.
Change subject: sla: Add support for basic PolicyUnit testing
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/39728/12/backend/manager/modules/bll/src/main/java/org/ov
Martin Sivák has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/40136/6/backend/manager/modules/bll/src/
Martin Sivák has posted comments on this change.
Change subject: sla: Add support for basic PolicyUnit testing
..
Patch Set 12:
(3 comments)
https://gerrit.ovirt.org/#/c/39728/12/backend/manager/modules/bll/src/main/java/org/o
Martin Sivák has posted comments on this change.
Change subject: sla: Update balancers and add memory based load balancing
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/38189/4/backend/manager/modules/bll/src/main/
Martin Sivák has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 6:
(4 comments)
https://gerrit.ovirt.org/#/c/40136/6/backend/manager/modules/bll/src/
Martin Sivák has posted comments on this change.
Change subject: sla: Update balancers and add memory based load balancing
..
Patch Set 4:
(10 comments)
https://gerrit.ovirt.org/#/c/38189/4/backend/manager/modules/bll/src/main
Martin Sivák has posted comments on this change.
Change subject: core: Use ToStringBuilder in sla classes
..
Patch Set 1: Code-Review+1
On the other hand, I think it is a good idea to have a code that takes care of
this and fr
Martin Sivák has submitted this change and it was merged.
Change subject: packaging: spec: cleanings
..
packaging: spec: cleanings
Change-Id: I6634f08d0403cd4c8036ed315d5ddc101cd340bd
Signed-off-by: Sandro Bonazzola
---
M ovir
Martin Sivák has posted comments on this change.
Change subject: packaging: spec: cleanings
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39970
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Sivák has posted comments on this change.
Change subject: PendingResourceManager for tracking resources in WaitForLaunch
..
Patch Set 2:
Hi,
this is a proof of concept patch that should allow us to drop the horrible
pe
Martin Sivák has posted comments on this change.
Change subject: engine: scheduling host- find free VF
..
Patch Set 16: Code-Review+1
Much better thanks. I would still like Roy or Gilad to attach their opinion
though.
--
To
Martin Sivák has posted comments on this change.
Change subject: engine: scheduling host- find free VF
..
Patch Set 14: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/37931
To unsubscribe, visit https://gerrit.ovirt.
1 - 100 of 1118 matches
Mail list logo
