Hello Jiří Moskovčák,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40820
to review the following change.
Change subject: respect the timeout in EngineUpBadHealth state (better fix)
......................................................................
respect the timeout in EngineUpBadHealth state (better fix)
Change-Id: Id86274fabe5f66ee42fc0235a4091205afedd79c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150600
Signed-off-by: Jiri Moskovcak <jmosk...@redhat.com>
---
M ovirt_hosted_engine_ha/agent/states.py
1 file changed, 0 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-ha
refs/changes/20/40820/1
diff --git a/ovirt_hosted_engine_ha/agent/states.py
b/ovirt_hosted_engine_ha/agent/states.py
index 4373b5e..90446a9 100644
--- a/ovirt_hosted_engine_ha/agent/states.py
+++ b/ovirt_hosted_engine_ha/agent/states.py
@@ -562,20 +562,6 @@
(now - fail_time))
return super(EngineUpBadHealth, self).consume(fsm, new_data, logger)
- def score(self, logger):
- # the timeout_start_time is None if the state just changed
- if self.data.timeout_start_time:
- time_str = time.ctime(self.data.timeout_start_time
- + self.data.stats.time_epoch)
- else:
- time_str = time.ctime()
- # If engine has bad health status, let another host try
- logger.info('Score is 0 due to bad engine health at %s',
- time_str,
- extra=log_filter.lf_args('score-health',
- self.LF_PENALTY_INT))
- return 0
-
def metadata(self):
data = super(EngineUpBadHealth, self).metadata()
if self.data.timeout_start_time:
--
To view, visit https://gerrit.ovirt.org/40820
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id86274fabe5f66ee42fc0235a4091205afedd79c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
