Martin Sivák has posted comments on this change. Change subject: Allow using unix socket for the RPC port ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/42228/2/configure.ac File configure.ac: Line 17 Line 18 Line 19 Line 20 Line 21 > The version bump should be a separate patch that concerns itself only with It was not supposed to stay here :) https://gerrit.ovirt.org/#/c/42228/2/mom/unixrpc.py File mom/unixrpc.py: Line 8: # distributed under the License is distributed on an "AS IS" BASIS, Line 9: # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. Line 10: # See the License for the specific language governing permissions and Line 11: # limitations under the License. Line 12: > This would make MOM a mixed license project. Are we even able to mix this Yep, you can use Apache license in GPL project. The code is simple enough to take it as is and relicense, but I do not think it would be fair :) Line 13: # This module contains code that implements a XML-RPC client/server. Line 14: # Taken from https://github.com/tmbx/kpython on the 11th of June 2015 at 14:52 CEST Line 15: # using the git commit revision dea4a6cc07 Line 16: # Authors: -- To view, visit https://gerrit.ovirt.org/42228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6617d92c94259dff604acaa2b6481ef9595522a4 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
