Martin Sivák has posted comments on this change. Change subject: sla: Update balancers and add memory based load balancing ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/38189/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java: Line 296: } Line 297: } Line 298: return defaultValue; Line 299: } Line 300: > one last thing - just missing some documentation on these abstract method w Done Line 301: protected abstract FindVmAndDestinations getFindVmAndDestinations(VDSGroup cluster, Line 302: Map<String, String> parameters); Line 303: Line 304: protected abstract List<VDS> getPrimarySources(VDSGroup cluster, -- To view, visit https://gerrit.ovirt.org/38189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fe13267feca89ab6c8fb9d85656f05930d0b333 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
