Martin Sivák has posted comments on this change. Change subject: New hypervisor interface for remote VDSM over XML-RPC with stats caching ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41570/2/mom/HypervisorInterfaces/remoteVdsmInterface.py File mom/HypervisorInterfaces/remoteVdsmInterface.py: Line 53: Line 54: def __init__(self): Line 55: self.logger = logging.getLogger('mom.vdsmInterface') Line 56: try: Line 57: self.vdsm_api = vdscli.connect() > I wonder how this behaves when VDSM restarts for whatever reason. Does vdsc It doesn't. The mom-vdsm service (in vdsm) has a hard requirement on vdsm so mom will be restarted by systemd. But we should catch a different issue. VDSM rpc reports vdsmException when getAllVmStats is called and VDSM is in recovering state. Line 58: response = self.vdsm_api.ping() Line 59: self._check_status(response) Line 60: except vdsmException, e: Line 61: e.handle_exception() -- To view, visit https://gerrit.ovirt.org/41570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I314f39f9020ee257827145a57f585e7921a913e3 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
