Martin Sivák has posted comments on this change. Change subject: sla: Add support for basic PolicyUnit testing ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/39728/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java: Line 56: + curVds.getReservedMem(); Line 57: } Line 58: Line 59: public static Integer getEffectiveCpuCores(VDS vds, VdsGroupDAO vdsGroupDao) { Line 60: VDSGroup vdsGroup = vdsGroupDao.get(vds.getVdsGroupId()); > But what? It is a static method, so there is nothing else you can use even Done Line 61: return getEffectiveCpuCores(vds, vdsGroup != null ? vdsGroup.getCountThreadsAsCores() : false); Line 62: } Line 63: Line 64: public static Integer getEffectiveCpuCores(VDS vds, boolean countThreadsAsCores) { -- To view, visit https://gerrit.ovirt.org/39728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied30d4ac4c1eeee2911e5f276d5333982147effa Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
