Martin Sivák has posted comments on this change. Change subject: core: Allow removing a running Hosted Engine VM from the setup ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42296/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java: Line 198: break; Line 199: case Suspended: Line 200: return failCanDoAction(VdcBllMessages.VM_CANNOT_REMOVE_VM_WHEN_STATUS_IS_NOT_DOWN); Line 201: default: Line 202: return getVm().isHostedEngine() || failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_RUNNING); Won't this allow accidental removal from the UI? What about adding a parameter to the command that would have to be present for this override to be activated? Line 203: } Line 204: Line 205: if (getVm().getVmPoolId() != null) { Line 206: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_ATTACHED_TO_POOL); -- To view, visit https://gerrit.ovirt.org/42296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c216ac6052ddf7eddba0f45bdc0f2edd87a252 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
